Client hints updates #4907

 ---
-<div>{{HTTPSidebar}}{{securecontext_header}}{{Deprecated_header}}{{Non-standard_header}}</div>
+<div>{{HTTPSidebar}}{{securecontext_header}}{{Deprecated_header}}</div>


Note, this is non-standard. Last time I had both that and a deprecated header Chris suggested the deprecated header along covers that you should not use it.

files/en-us/web/http/headers/accept-ch/index.html

hamishwillee · 2021-05-21T04:53:12Z

files/en-us/glossary/forbidden_header_name/index.html

@@ -26,7 +26,7 @@
 <li><code>Date</code></li>
 <li><code>DNT</code></li>
 <li><code>Expect</code></li>
- <li><code>Feature-Policy</code></li>
+ <li><code>Feature-Policy</code></li> 


@Elchi3 How does one find out if something is a forbidden header name? Specifically, I checked the Fetch spec, and it matches the list here except it does not mention Feature-Policy. So how would I find out that Feature Policy is forbidden (I searched on forbidden in the permission-policy spec too and the term does not appear).

The main reason I ask is that the client hints all have "?" in the table for forbidden, so would help me to understand how you confirm their status.

Further, w.r.t. this doc, should I also add Permission-Policy?

Actually it's Permissions-Policy with an 's'.

I thought the list from the Fetch spec is exhaustive and new forbidden headers would start with Sec- but maybe that is a misunderstanding from my side.

I previously only confirmed these by looking at the Fetch spec...

Thanks @Elchi3. The fetch spec being exhaustive seems a reasonable assumption. Just wasn't one I wanted to make. Happy to go with that now.

I wont add Permissions-Policy because I now know that this will be done "all in one go" later on.

files/en-us/web/http/headers/accept-ch/index.html

hamishwillee · 2021-05-21T06:32:23Z

Hi @Elchi3
I'm trying to work out if we have missed any Client hint headers in docs.

We already document these headers:

Device-Memory
Viewport-Width
Width
Save-Data
- Note, need to add that this is a low entropy hint (ie one that will likely be sent even if not requested using Accept-CH).
- Note, need to document what low entropy hints are.
(Deprecated and not in the spec) Accept-CH-Lifetime
(Deprecated BCD and is in the current spec DPR)

I think we are missing these (do you know of any reason not to include them)?:

Viewport-Height
RTT
Downlink
ECT

Further there are a bunch of new User Agent Client Hints. These are defined in a "Draft Community Group Report, 4 May 2021" (i.e. not a standards track thingy yet). I haven't done a full check but at least some of these are implemented in chrome 90 (and not yet in firefox https://bugzilla.mozilla.org/show_bug.cgi?id=935216#c67). What is our position on documenting these? (i.e. "do we document these"?):

Sec-CH-UA - low entropy hint.
Sec-CH-UA-Arch
Sec-CH-UA-Bitness
Sec-CH-UA-Full-Version
Sec-CH-UA-Mobile - low entropy hint.
Sec-CH-UA-Model
Sec-CH-UA-Platform - low entropy hint.
Sec-CH-UA-Platform-Version

Are there any others you know of?

Last of all, can you please review and merge this if it is OK? I'd like to do follow on fixes with bumping against other work people are doing :-)

chrisdavidmills · 2021-05-21T07:19:35Z

Seems that @Elchi3 is a better choice of official reviewer for this one.

hamishwillee · 2021-05-26T23:05:56Z

@Elchi3 (or @chrisdavidmills ) do you think you might have time to look at this today? Then I can continue the work tomorrow :-)

Elchi3 · 2021-05-27T17:49:58Z

Sorry Hamish, I will try to get to it but probably not this week.

hamishwillee · 2021-05-28T00:37:27Z

@Elchi3 Thank you - just wanted to make sure this was on your radar. Plenty to go on with :-)

FWIW An answer to the question above in #4907 (comment) is more useful than an actual review of the PR, as it would unblock me.

Elchi3 · 2021-05-31T14:38:48Z

I think we are missing these (do you know of any reason not to include them)?:

Viewport-Height

RTT

Downlink

ECT

These look good to me, although I'm not sure there is a (somewhat stable) specification for Viewport-Height. Maybe leave this out for now? (or maybe I'm missing something, pointers to specs appreciated).

What is our position on documenting these? (i.e. "do we document these"?):

Sec-CH-UA - low entropy hint.

Sec-CH-UA-Arch

Sec-CH-UA-Bitness

Sec-CH-UA-Full-Version

Sec-CH-UA-Mobile - low entropy hint.

Sec-CH-UA-Model

Sec-CH-UA-Platform - low entropy hint.

Sec-CH-UA-Platform-Version

Not sure who "ours" is in "our position". Mozilla thinks is it "non-harmful" in https://mozilla.github.io/standards-positions/
My feeling is we could document this now but maybe check what you know against https://developer.mozilla.org/en-US/docs/MDN/Guidelines/Conventions_definitions#when_to_document_new_technologies?

Are there any others you know of?

There seem to be quite a few Client hints specs but it looks like you got the main ones here. Of course things are always in flux...

Elchi3

Thanks for the PR! Some nits but LGTM otherwise

files/en-us/glossary/client_hints/index.html

Elchi3 · 2021-05-31T15:06:41Z

files/en-us/web/http/headers/dpr/index.html

  - Deprecated
  - Non-standard
+  - Exerimental


Deprecated, non-standard, experimental? What is going on here?

@Elchi3 This is a reflection of the BCD.

Previously experimental was omitted - so all I did was add the tag as well (this updates the sidebar with the icon).

Elchi3 · 2021-05-31T15:07:24Z

files/en-us/web/http/headers/index.html

@@ -81,12 +81,12 @@ <h2 id="Client_hints">Client hints</h2>
 <dl>
 <dt>{{HTTPHeader("Accept-CH")}} {{experimental_inline}}</dt>
 <dd>Servers can advertise support for Client Hints using the <code>Accept-CH</code> header field or an equivalent HTML <code>&lt;meta&gt;</code> element with <code>http-equiv</code> attribute (<a href="https://html.spec.whatwg.org/multipage/semantics.html#attr-meta-http-equiv"><cite>[HTML]</cite></a>).</dd>
- <dt>{{HTTPHeader("Accept-CH-Lifetime")}} {{experimental_inline}}</dt>
+ <dt>{{HTTPHeader("Accept-CH-Lifetime")}} {{experimental_inline}} {{deprecated_inline}}</dt>


No longer experimental?

@Elchi3 Still experimental but also deprecated.

For all of these I matched the docs to BCD. Note that arguably for page headers you only need one of these - the deprecated. But since I can't find a clear policy on that I haven't removed the other headers. I have been trying to discuss/get agreement on that in the context of auto-generation of headers from BCD.

Thanks for matching BCD, let's go with this then.

Co-authored-by: Florian Scholz <fs@florianscholz.com>

hamishwillee · 2021-06-01T07:24:33Z

@Elchi3 I think I've either merged or answered your nits, and also fixed the conflicts.

Thanks very much for the info on which headers to document. That will come as follow on.

Elchi3

Thanks Hamish! 🎉

hamishwillee closed this May 11, 2021

hamishwillee force-pushed the http_accept-ch branch from fb9755c to 306b354 Compare May 11, 2021 08:09

hamishwillee reopened this May 11, 2021

hamishwillee commented May 21, 2021

View reviewed changes

files/en-us/web/http/headers/accept-ch/index.html Show resolved Hide resolved

Client hints, general updates

c54fa6f

hamishwillee force-pushed the http_accept-ch branch from 57bedf7 to c54fa6f Compare May 21, 2021 04:27

Assorted minor changes, mostly to frontmatter

2b9b979

hamishwillee commented May 21, 2021

View reviewed changes

files/en-us/web/http/headers/accept-ch/index.html Show resolved Hide resolved

hamishwillee added 2 commits May 21, 2021 15:32

Early-data is not a client hint header

744e59b

Minor fixes

233056d

hamishwillee marked this pull request as ready for review May 21, 2021 06:32

hamishwillee requested review from a team as code owners May 21, 2021 06:32

hamishwillee requested review from chrisdavidmills and removed request for a team May 21, 2021 06:32

chrisdavidmills requested review from Elchi3 and removed request for chrisdavidmills May 21, 2021 07:19

hamishwillee mentioned this pull request May 25, 2021

Document the the X-Requested-With HTTP header #4178

Closed

Merge branch 'main' into http_accept-ch

cfe9752

Elchi3 requested changes May 31, 2021

View reviewed changes

Update files/en-us/glossary/client_hints/index.html

0deed1b

Co-authored-by: Florian Scholz <fs@florianscholz.com>

hamishwillee and others added 2 commits June 1, 2021 17:16

Update files/en-us/glossary/client_hints/index.html

40c1639

Co-authored-by: Florian Scholz <fs@florianscholz.com>

Merge branch 'main' into http_accept-ch

d33e26b

Elchi3 approved these changes Jun 1, 2021

View reviewed changes

Elchi3 merged commit 7a06a72 into mdn:main Jun 1, 2021

hamishwillee deleted the http_accept-ch branch June 1, 2021 08:38

This was referenced Jun 4, 2021

Incomplete information for Accept-CH page #1408

Closed

Http client headers updates #5784

Merged

github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Client hints updates #4907

Client hints updates #4907

hamishwillee commented May 11, 2021 •

edited

Loading

github-actions bot commented May 11, 2021 •

edited

Loading

hamishwillee May 21, 2021

hamishwillee May 21, 2021

jpmedley May 24, 2021

Elchi3 May 31, 2021

hamishwillee Jun 1, 2021

hamishwillee commented May 21, 2021

chrisdavidmills commented May 21, 2021

hamishwillee commented May 26, 2021

Elchi3 commented May 27, 2021

hamishwillee commented May 28, 2021

Elchi3 commented May 31, 2021

Elchi3 left a comment

Elchi3 May 31, 2021

hamishwillee Jun 1, 2021

Elchi3 May 31, 2021

hamishwillee Jun 1, 2021

hamishwillee Jun 1, 2021

Elchi3 Jun 1, 2021

hamishwillee commented Jun 1, 2021

Elchi3 left a comment

Client hints updates #4907

Client hints updates #4907

Conversation

hamishwillee commented May 11, 2021 • edited Loading

github-actions bot commented May 11, 2021 • edited Loading

Preview URLs

Flaws

External URLs

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hamishwillee commented May 21, 2021

chrisdavidmills commented May 21, 2021

hamishwillee commented May 26, 2021

Elchi3 commented May 27, 2021

hamishwillee commented May 28, 2021

Elchi3 commented May 31, 2021

Elchi3 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hamishwillee commented Jun 1, 2021

Elchi3 left a comment

Choose a reason for hiding this comment

hamishwillee commented May 11, 2021 •

edited

Loading

github-actions bot commented May 11, 2021 •

edited

Loading