Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New page: dateTime property #36987

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

New page: dateTime property #36987

wants to merge 8 commits into from

Conversation

estelle
Copy link
Member

@estelle estelle commented Nov 26, 2024

Part of missing baseline project

  • Add missing HTMLModElement.dateTime reference
  • improve see also and intro of HTMLTimeElement.dateTime slightly.

@estelle estelle requested a review from a team as a code owner November 26, 2024 23:06
@estelle estelle requested review from wbamberg and removed request for a team November 26, 2024 23:06
@github-actions github-actions bot added Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed labels Nov 26, 2024
Copy link
Contributor

github-actions bot commented Nov 26, 2024

Preview URLs

(comment last updated: 2025-01-06 21:25:19)

We can also set the `dateTime` property. Here, we create an element, set the `dateTime` to the current date, add content, then insert it after the deleted text:

```js
const = document.createElement("ins");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const = document.createElement("ins");
const el2 = document.createElement("ins");

el2.dateTime = `${now.getFullYear()}-${now.getMonth() + 1}-${now.getDate()}`;
el2.innerHTML = " was"
el1.insertAdjacentElement("afterend", el2);
```
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not really clear to me what this example is trying to do. Is it supposed to follow on from the previous example? In that case presumably el1 should be deletion.

Perhaps making this whole thing into a live sample, where the user can show the value of both attributes, might help? You could have an example which starts out with something like:

<p>This paragraph <span>can be</span> changed.</p>

...and have a button to change it:

<p>This paragraph
  <del datetime=the-date>can be</del>
  <ins datetime=the-date>has been</ins> changed.</p>

...and have a button to show the values. And another button a reset so they can try again.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also if el1 should be deletion maybe el2 should be insertion? Or maybe deletedText and insertedText?

const = document.createElement("ins");
const now = new Date();
el2.dateTime = `${now.getFullYear()}-${now.getMonth() + 1}-${now.getDate()}`;
el2.innerHTML = " was"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't use innerHTML for setting text.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants