-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New page: dateTime property #36987
base: main
Are you sure you want to change the base?
New page: dateTime property #36987
Conversation
Preview URLs (comment last updated: 2025-01-06 21:25:19) |
We can also set the `dateTime` property. Here, we create an element, set the `dateTime` to the current date, add content, then insert it after the deleted text: | ||
|
||
```js | ||
const = document.createElement("ins"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const = document.createElement("ins"); | |
const el2 = document.createElement("ins"); |
el2.dateTime = `${now.getFullYear()}-${now.getMonth() + 1}-${now.getDate()}`; | ||
el2.innerHTML = " was" | ||
el1.insertAdjacentElement("afterend", el2); | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not really clear to me what this example is trying to do. Is it supposed to follow on from the previous example? In that case presumably el1
should be deletion
.
Perhaps making this whole thing into a live sample, where the user can show the value of both attributes, might help? You could have an example which starts out with something like:
<p>This paragraph <span>can be</span> changed.</p>
...and have a button to change it:
<p>This paragraph
<del datetime=the-date>can be</del>
<ins datetime=the-date>has been</ins> changed.</p>
...and have a button to show the values. And another button a reset so they can try again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also if el1
should be deletion
maybe el2
should be insertion
? Or maybe deletedText
and insertedText
?
const = document.createElement("ins"); | ||
const now = new Date(); | ||
el2.dateTime = `${now.getFullYear()}-${now.getMonth() + 1}-${now.getDate()}`; | ||
el2.innerHTML = " was" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We shouldn't use innerHTML
for setting text.
Part of missing baseline project