36125 add text emphasis position auto #36331
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dletorey
requested review from
estelle and
dipikabh
and removed request for
a team and
estelle
|
Preview URLs (comment last updated: 2024-10-17 10:13:10) |
This was referenced Oct 14, 2024
In this preview, it looks like the "Formal definition" and "Formal syntax" sections still need an update. |
Those can be found in the following Pull Request: |
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…deRedDigital/content into 36125-add-text-emphasis-position-auto
dipikabh
requested changes
Oct 16, 2024
dipikabh
requested changes
Oct 16, 2024
dipikabh
requested changes
Oct 16, 2024
dipikabh
approved these changes
Oct 16, 2024
There was a problem hiding this comment.
Thanks for the updates, @dletorey. They're looking good so leaving a +1.
A few nits need to be resolved before this PR is merged. I'm not seeing the option to apply the suggested changes else I would have committed them.
Update: The writing-mode property can be added to the "See also". And maybe also text-underline-position.
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
…deRedDigital/content into 36125-add-text-emphasis-position-auto
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
autovalue to Valuesautointo SyntaxMotivation
Working on issue #36125
Additional details
autovalue fortext-emphasis-positionRelated issues and pull requests