BodyInit also allows ReadableStream #35949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Content:WebAPI
|
Preview URLs (comment last updated: 2024-09-19 15:06:37) |
|
Thank you! We also list the types here: https://developer.mozilla.org/en-US/docs/Web/API/Fetch_API/Using_Fetch#setting_a_body , would you mind adding ReadableStream there as well? |
mhart
force-pushed
the
patch-1
branch
2 times, most recently
from
95c2ada
to
d268168
Compare
Good pickup, thanks @wbamberg – added that too |
See relevant section of the spec: https://fetch.spec.whatwg.org/#bodyinit-unions
wbamberg
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
bodyoption supplied to theRequestconstructor (BodyInit) also allowsReadableStreamaccording to the spec (and implementations)Motivation
The above option appears to not be documented (unless I missed it?)