-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change Notification().silent default | update #35904
Conversation
Preview URLs
External URLs (2)URL:
URL:
(comment last updated: 2024-09-18 16:20:22) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've also done other changes:
- Unify the wordings used for the options on the two API pages
- Reorder and re-format the option lists
- Update the exceptions part a bit
So syncing changes in the future should be more straightforward. I've not done any real content changes. Thanks for the PR.
Description
this is a follow up PR of #35714, which fix the default value in ServiceWorkerRegistration.showNotification()
see the detail at #35714, #31706, #26812 and spec PR at whatwg/notifications#194
and add additional detail to mdn/browser-compat-data#24276
Motivation
Additional details
Related issues and pull requests