Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pages for HTML*Element.willValidate #35665

Merged
merged 2 commits into from
Sep 11, 2024
Merged

Add pages for HTML*Element.willValidate #35665

merged 2 commits into from
Sep 11, 2024

Conversation

Josh-Cena
Copy link
Member

Part of #35544

@Josh-Cena Josh-Cena requested a review from a team as a code owner August 31, 2024 20:22
@Josh-Cena Josh-Cena requested review from sideshowbarker and removed request for a team August 31, 2024 20:22
@github-actions github-actions bot added the Content:WebAPI Web API docs label Aug 31, 2024
@Josh-Cena Josh-Cena requested review from estelle and removed request for sideshowbarker August 31, 2024 20:22
@github-actions github-actions bot added the size/m [PR only] 51-500 LoC changed label Aug 31, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 31, 2024 •
edited
Loading

Preview URLs (8 pages)
Flaws (6)

Note! 6 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/HTMLTextAreaElement/willValidate
Title: HTMLTextAreaElement: willValidate property
Flaw count: 2

  • macros:
    • /en-US/docs/Web/API/HTMLTextAreaElement/disabled does not exist
    • /en-US/docs/Web/API/HTMLTextAreaElement/readOnly does not exist

URL: /en-US/docs/Web/API/HTMLOutputElement
Title: HTMLOutputElement
Flaw count: 4

  • macros:
    • /en-US/docs/Web/API/HTMLOutputElement/defaultValue does not exist
    • /en-US/docs/Web/API/HTMLOutputElement/htmlFor does not exist
    • /en-US/docs/Web/API/HTMLOutputElement/validationMessage does not exist
    • /en-US/docs/Web/API/HTMLOutputElement/setCustomValidity does not exist

(comment last updated: 2024-09-11 00:57:39)

estelle
estelle approved these changes Sep 11, 2024
View reviewed changes
Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor suggestions for your consideration. approving. Thank you!

files/en-us/web/api/htmlbuttonelement/willvalidate/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/htmlinputelement/willvalidate/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/htmlselectelement/willvalidate/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/htmltextareaelement/willvalidate/index.md Outdated Show resolved Hide resolved
@Josh-Cena
Copy link
Member Author

Thanks for the reviews! I mostly just applied them, so merging.

@Josh-Cena Josh-Cena merged commit 4524e28 into mdn:main Sep 11, 2024
8 checks passed
@Josh-Cena Josh-Cena deleted the willvalidate branch September 11, 2024 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estelle estelle estelle approved these changes

Assignees
No one assigned
Labels
Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Josh-Cena @estelle