Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New pages: HTMLMeterElement properties #35638

Merged
merged 2 commits into from
Aug 29, 2024
Merged

New pages: HTMLMeterElement properties #35638

merged 2 commits into from
Aug 29, 2024

Conversation

estelle
Copy link
Member

@estelle estelle commented Aug 29, 2024

Part of #35544

@estelle estelle requested a review from a team as a code owner August 29, 2024 18:00
@estelle estelle requested review from wbamberg and removed request for a team August 29, 2024 18:00
@github-actions github-actions bot added Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed labels Aug 29, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 29, 2024 •
edited
Loading

Preview URLs (6 pages)

(comment last updated: 2024-08-29 20:40:45)

Josh-Cena
Josh-Cena reviewed Aug 29, 2024
View reviewed changes
Copy link
Member

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost good

files/en-us/web/api/htmlmeterelement/high/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/htmlmeterelement/low/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/htmlmeterelement/high/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/htmlmeterelement/low/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/htmlmeterelement/max/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/htmlmeterelement/min/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/htmlmeterelement/optimum/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/htmlmeterelement/optimum/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/htmlmeterelement/value/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/htmlmeterelement/value/index.md Outdated Show resolved Hide resolved
@estelle @Josh-Cena
Apply suggestions from code review
41ef00d 
Co-authored-by: Joshua Chen <sidachen2003@gmail.com>
@estelle estelle requested a review from Josh-Cena August 29, 2024 20:39
@estelle
Copy link
Member Author

estelle commented Aug 29, 2024

Thanks @Josh-Cena

Josh-Cena
Josh-Cena approved these changes Aug 29, 2024
View reviewed changes
Copy link
Member

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks

@Josh-Cena Josh-Cena merged commit f36d86d into main Aug 29, 2024
9 checks passed
@Josh-Cena Josh-Cena deleted the meter branch August 29, 2024 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Josh-Cena Josh-Cena Josh-Cena approved these changes

@wbamberg wbamberg Awaiting requested review from wbamberg wbamberg is a code owner automatically assigned from mdn/yari-content-web-api

Assignees
No one assigned
Labels
Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@estelle @Josh-Cena