Make meaning of parentheses for regex explicit in URL Pattern API #35571
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A URLPattern uses parentheses to define Regexs as shown in one fo the examples currently on MDN:
Here the
(\\d+)
is a regex as it's surrounded by parentheses. However it's not obvious that parentheses are what allow you to use regular expressions since they are so common (especially in regexes themselves when they defined groups) so this is easily missed. So I'm suggesting wording to make this more explicit.Motivation
I didn't understand this and wasted a lot of time on it. I'm hoping to avoid others doing the same.
Additional details
I also raised an issue for the spec to see if they want to make it clearer too:
whatwg/urlpattern#229
Related issues and pull requests