Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(learn/css): restructure guides navigation #34534

Merged
merged 2 commits into from
Jul 1, 2024
Merged

fix(learn/css): restructure guides navigation #34534

merged 2 commits into from
Jul 1, 2024

Conversation

OnkarRuikar
Copy link
Contributor

The PR implements following suggestion:

If so then I think the right thing to do would be to:

remove the "See also" section from CSS Building blocks, and move the Advanced styling effects link under Guides instead (perhaps just before "Debugging CSS"?)
update the other nav elements (e.g. the Next/Previous buttons) to splice in the "Advanced styling effects" article at that point.

@OnkarRuikar OnkarRuikar requested a review from a team as a code owner July 1, 2024 08:25
@OnkarRuikar OnkarRuikar requested review from dipikabh and removed request for a team July 1, 2024 08:25
@github-actions github-actions bot added Content:Learn:CSS Learning area CSS docs size/s [PR only] 6-50 LoC changed labels Jul 1, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 1, 2024 •
edited
Loading

Preview URLs

(comment last updated: 2024-07-01 08:34:24)

@OnkarRuikar OnkarRuikar mentioned this pull request Jul 1, 2024
Merged
wbamberg
wbamberg approved these changes Jul 1, 2024
View reviewed changes
Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 this looks great @OnkarRuikar , thank you for picking it up.

@wbamberg wbamberg merged commit adc54f3 into mdn:main Jul 1, 2024
8 checks passed
@OnkarRuikar OnkarRuikar deleted the learn_css_ordering branch July 2, 2024 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wbamberg wbamberg wbamberg approved these changes

@dipikabh dipikabh Awaiting requested review from dipikabh dipikabh is a code owner automatically assigned from mdn/yari-content-css

Assignees
No one assigned
Labels
Content:Learn:CSS Learning area CSS docs size/s [PR only] 6-50 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Advanced styling effects": the navigation could be a lot better
2 participants
@OnkarRuikar @wbamberg