Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the blocking attribute of the <link> element example #33469

Merged
merged 1 commit into from
May 8, 2024
Merged

Fix the blocking attribute of the <link> element example #33469

merged 1 commit into from
May 8, 2024

Conversation

skyclouds2001
Copy link
Contributor

Description

see https://html.spec.whatwg.org/multipage/semantics.html#attr-link-blocking and https://html.spec.whatwg.org/multipage/links.html#link-type-stylesheet, https://html.spec.whatwg.org/multipage/links.html#link-type-expect

the blocking attribute of the <link> element can only used when rel attribute containing expect or stylesheet keywords

Motivation

Additional details

Related issues and pull requests

@github-actions github-actions bot added Content:HTML Hypertext Markup Language docs size/s [PR only] 6-50 LoC changed labels May 7, 2024
@skyclouds2001 skyclouds2001 marked this pull request as ready for review May 7, 2024 13:35
@skyclouds2001 skyclouds2001 requested a review from a team as a code owner May 7, 2024 13:35
@skyclouds2001 skyclouds2001 requested review from estelle and removed request for a team May 7, 2024 13:35
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 7, 2024

Preview URLs

teoli2003
teoli2003 approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@teoli2003 teoli2003 merged commit 5c158de into mdn:main May 8, 2024
7 checks passed
@skyclouds2001 skyclouds2001 deleted the fix-link-blocking-example branch May 8, 2024 05:15
dalps pushed a commit to dalps/content that referenced this pull request May 8, 2024
@skyclouds2001 @dalps
Fix the blocking attribute of the <link> element example (mdn#33469)
f6640ad 
fix
@skyclouds2001 skyclouds2001 mentioned this pull request May 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teoli2003 teoli2003 teoli2003 approved these changes

@estelle estelle Awaiting requested review from estelle estelle is a code owner automatically assigned from mdn/yari-content-html

Assignees
No one assigned
Labels
Content:HTML Hypertext Markup Language docs size/s [PR only] 6-50 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skyclouds2001 @teoli2003