Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduction to the CSS basic box model - remove spec section #27147

Merged
merged 2 commits into from
Jun 5, 2023
Merged

Introduction to the CSS basic box model - remove spec section #27147

merged 2 commits into from
Jun 5, 2023

Conversation

hamishwillee
Copy link
Collaborator

@hamishwillee hamishwillee commented Jun 5, 2023 •
edited
Loading

Fixes #27085

Specifications section was not rendering because there was no metadata key.
The page is a guide, and should typically not include a specifications link section so I just removed it.

@hamishwillee hamishwillee requested a review from a team as a code owner June 5, 2023 00:21
@hamishwillee hamishwillee requested review from estelle and removed request for a team June 5, 2023 00:21
@github-actions github-actions bot added the Content:CSS Cascading Style Sheets docs label Jun 5, 2023
@hamishwillee hamishwillee mentioned this pull request Jun 5, 2023
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2023 •
edited
Loading

Preview URLs

(comment last updated: 2023-06-05 05:17:28)

Josh-Cena
Josh-Cena reviewed Jun 5, 2023
View reviewed changes
Copy link
Member

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_box_model/Mastering_margin_collapsing too?

@hamishwillee
Copy link
Collaborator Author

Sure. Done.

Josh-Cena
Josh-Cena approved these changes Jun 5, 2023
View reviewed changes
Copy link
Member

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, thanks!

@Josh-Cena Josh-Cena merged commit 9deefec into main Jun 5, 2023
@Josh-Cena Josh-Cena deleted the hamishwillee-patch-4 branch June 5, 2023 08:09
This was referenced Jun 5, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Josh-Cena Josh-Cena Josh-Cena approved these changes

@estelle estelle Awaiting requested review from estelle estelle is a code owner automatically assigned from mdn/yari-content-css

Assignees
No one assigned
Labels
Content:CSS Cascading Style Sheets docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Section called "Specifications" displays code, instead of intended text.
2 participants
@hamishwillee @Josh-Cena