Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add page types to the Web/Accessibility area #26140

Merged
merged 11 commits into from
Apr 12, 2023
Merged

Add page types to the Web/Accessibility area #26140

merged 11 commits into from
Apr 12, 2023

Conversation

teoli2003
Copy link
Contributor

@teoli2003 teoli2003 commented Apr 12, 2023 •
edited
Loading

Description

This PR adds page types to the Web/Accessibility section.

Motivation

Fixes #26116
Part of openwebdocs/project#91

Additional details

  • Added page-type:role to roles.
  • Added page-type:attribute to attributes.
  • Deleted Community and FAQ pages that were mostly empty and/or outdated
  • Moved ARIA/forms/Multipart_labels one level higher as it was the only page in this directory, and removed the above useless landing page (Form), which was empty. Removed a few links to this top page elsewhere on MDN.
  • Added page-type:guide to guide.
  • Added page-type:landing-page to landing pages.
  • Updated the writing guidelines with the two new specific page types.

I made separate commits for each of these updates.

This PR doesn't fix the multiple incoherent sidebars: A separate project will create a single unified sidebar for the Web/Accessibility section. We will then examine the information architecture for Web/Accessibility, but it is clearly outside the scope of this PR/issue.

@teoli2003 teoli2003 requested a review from wbamberg April 12, 2023 07:38
@teoli2003 teoli2003 requested review from a team as code owners April 12, 2023 07:38
@teoli2003 teoli2003 requested review from schalkneethling and estelle and removed request for a team April 12, 2023 07:38
@github-actions github-actions bot added Content:Accessibility Accessibility docs Content:CSS Cascading Style Sheets docs Content:HTML Hypertext Markup Language docs Content:Other Any docs not covered by another "Content:" label labels Apr 12, 2023
@teoli2003 teoli2003 changed the title A11y page types Add page types to the Web/Accessibility area Apr 12, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 12, 2023 •
edited
Loading

Preview URLs (175 pages)
Flaws (53)

Note! 155 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/Accessibility/Understanding_WCAG/Understandable
Title: Understandable
Flaw count: 1

  • macros:
    • /en-US/docs/Web/API/HTMLElement/oninput redirects to /en-US/docs/Web/API/HTMLElement/input_event

URL: /en-US/docs/Web/Accessibility/ARIA/Roles/rowheader_role
Title: ARIA: rowheader role
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/Accessibility/ARIA/Roles/gridell_role

URL: /en-US/docs/Web/Accessibility/ARIA/Roles/section_role
Title: ARIA: section role
Flaw count: 17

  • macros:
    • /en-US/docs/Web/HTML/Element/subscript does not exist
  • broken_links:
    • Can't resolve /en-US/docs/Web/Accessibility/ARIA/Roles/code_role
    • Can't resolve /en-US/docs/Web/Accessibility/ARIA/Roles/subscript_role
    • Can't resolve /en-US/docs/Web/Accessibility/ARIA/Roles/associationlist_role
    • Can't resolve /en-US/docs/Web/Accessibility/ARIA/Roles/associationlistitemkey_role
    • Can't resolve /en-US/docs/Web/Accessibility/ARIA/Roles/associationlistitemvalue_role
    • and 11 more flaws omitted

URL: /en-US/docs/Web/Accessibility/ARIA/Roles/input_role
Title: ARIA: input role
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/HTML/Element/input/

URL: /en-US/docs/Web/Accessibility/ARIA/ARIA_Screen_Reader_Implementors_Guide
Title: ARIA Screen Reader Implementors Guide
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/AJAX/WAI_ARIA_Live_Regions/API_Support

URL: /en-US/docs/Web/Accessibility/ARIA/ARIA_Techniques
Title: Using ARIA: Roles, states, and properties
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/Accessibility/ARIA/ARIA_Techniques/x-ms-aria-flowfrom

URL: /en-US/docs/Web/Accessibility/ARIA/Attributes/aria-posinset
Title: aria-posinset
Flaw count: 2

  • broken_links:
    • Can't resolve /en-US/docs/Web/Accessibility/ARIA/Roles/associationlistitemkey_role
    • Can't resolve /en-US/docs/Web/Accessibility/ARIA/Roles/associationlistitemvalue_role

URL: /en-US/docs/Web/Accessibility/ARIA/Attributes/aria-labelledby
Title: aria-labelledby
Flaw count: 10

  • broken_links:
    • Can't resolve /en-US/docs/Web/Accessibility/ARIA/Roles/code_role
    • Can't resolve /en-US/docs/Web/Accessibility/ARIA/Roles/caption_role
    • Can't resolve /en-US/docs/Web/Accessibility/ARIA/Roles/deletion_role
    • Can't resolve /en-US/docs/Web/Accessibility/ARIA/Roles/emphasis_role
    • Can't resolve /en-US/docs/Web/Accessibility/ARIA/Roles/_role
    • and 5 more flaws omitted

URL: /en-US/docs/Web/Accessibility/ARIA/Attributes/aria-dropeffect
Title: aria-dropeffect
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/API/Document/dragstart_event

URL: /en-US/docs/Web/Accessibility/ARIA/Attributes/aria-colspan
Title: aria-colspan
Flaw count: 1

  • macros:
    • /en-US/docs/Web/API/ARIAMixin does not exist

URL: /en-US/docs/Web/Accessibility/ARIA/Attributes/aria-live
Title: aria-live
Flaw count: 1

  • macros:
    • /en-US/docs/Web/API/ElementInternals/aria-live does not exist

URL: /en-US/docs/Web/Accessibility/ARIA/Attributes/aria-level
Title: aria-level
Flaw count: 3

  • broken_links:
    • Can't resolve /en-US/docs/Web/Accessibility/Attributes/aria-setsize
    • Can't resolve /en-US/docs/Web/Accessibility/Attributes/aria-posinset
    • Can't resolve /en-US/docs/Web/Accessibility/ARIA/Roles/associationlistitemkey_role

URL: /en-US/docs/Web/Accessibility/ARIA/Attributes/aria-busy
Title: aria-busy
Flaw count: 2

  • macros:
    • /en-US/docs/Web/API/ARIAMixin does not exist
    • /en-US/docs/Web/API/ARIAMixin does not exist

URL: /en-US/docs/Web/Accessibility/ARIA/Attributes/aria-rowindextext
Title: aria-rowindextext
Flaw count: 2

  • macros:
    • /en-US/docs/Web/HTML/Element/row does not exist
  • broken_links:
    • Can't resolve /en-US/docs/Web/Accessibility/ARIA/Attributes/aria-spanindex

URL: /en-US/docs/Web/Accessibility/ARIA/Attributes/aria-colcount
Title: aria-colcount
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/Accessibility/ARIA/Role/Table_role/

URL: /en-US/docs/Web/Accessibility/ARIA/Attributes/aria-valuemin
Title: aria-valuemin
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/Accessibility/ARIA/Attributes/aria-aria-valuenow

URL: /en-US/docs/Web/Accessibility/ARIA/Attributes/aria-checked
Title: aria-checked
Flaw count: 2

  • broken_links:
    • Can't resolve /en-US/docs/Web/HTML/Element/Input/checkbox
    • Can't resolve /en-US/docs/Web/HTML/Element/Input/radio

URL: /en-US/docs/Web/Accessibility/ARIA/Attributes/aria-controls
Title: aria-controls
Flaw count: 1

  • macros:
    • /en-US/docs/Web/API/ARIAMixin does not exist

URL: /en-US/docs/Web/Accessibility/ARIA/Attributes/aria-grabbed
Title: aria-grabbed
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/API/Document/dragstart_event

URL: /en-US/docs/Web/Accessibility/ARIA/Attributes/aria-setsize
Title: aria-setsize
Flaw count: 3

  • broken_links:
    • Can't resolve /en-US/docs/Web/Accessibility/aria/Attributes/aria-level
    • Can't resolve /en-US/docs/Web/Accessibility/ARIA/Roles/associationlistitemkey_role
    • Can't resolve /en-US/docs/Web/Accessibility/ARIA/Roles/associationlistitemvalue_role
External URLs (7)

URL: /en-US/docs/Web/HTML/Element/input/tel
Title: <input type="tel">

URL: /en-US/docs/Web/HTML/Element/input/submit
Title: <input type="submit">

URL: /en-US/docs/Web/CSS/::placeholder
Title: ::placeholder

(comment last updated: 2023-04-12 07:56:12)

wbamberg
wbamberg approved these changes Apr 12, 2023
View reviewed changes
Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thank you!

@wbamberg wbamberg merged commit f6d04a4 into mdn:main Apr 12, 2023
yin1999 added a commit to mdn/translated-content that referenced this pull request Apr 13, 2023
@yin1999
remove ARIA/forms
8eea7ef 
ref: mdn/content#26140
yin1999 added a commit to mdn/translated-content that referenced this pull request Apr 13, 2023
@mdn-bot @yin1999
[zh-tw] sync translated content (#12704)
39ec9f2 
* zh-tw: sync translated content

* remove ARIA/forms

ref: mdn/content#26140

---------

Co-authored-by: Allo <yin199909@aliyun.com>
yin1999 added a commit to mdn/translated-content that referenced this pull request Apr 13, 2023
@yin1999
remove ARIA/forms
1b5db49 
ref: mdn/content#26140
yin1999 added a commit to mdn/translated-content that referenced this pull request Apr 13, 2023
@mdn-bot @yin1999
[zh-cn] sync translated content (#12706)
bcaa670 
* zh-cn: sync translated content

* remove ARIA/forms

ref: mdn/content#26140

* Remove documentation for <content> element

ref: mdn/content#25352

* Remove <shadow>

ref: mdn/content#26122

---------

Co-authored-by: Allo <yin199909@aliyun.com>
Mehrm0 pushed a commit to Mehrm0/content that referenced this pull request Apr 14, 2023
@teoli2003 @Mehrm0
Add page types to the Web/Accessibility area (mdn#26140)
56b93ad 
* Add page-type aria-attribute

* Add page-type aria-role

* Delete Accessible_dynamic_content that was already emptied

* Delete Mozilla-only A11y faq

* Delete outdated a11y community page

* Move ARIA/Multipart_labels one level up

* Add page-type:landing-page to relevant A11Y pages

* Add page-type:guide to A11Y guides

* Update page-type list

* Fix forgotten broken link

* Fix redirect file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wbamberg wbamberg wbamberg approved these changes

@schalkneethling schalkneethling Awaiting requested review from schalkneethling schalkneethling is a code owner automatically assigned from mdn/yari-content-html

@estelle estelle Awaiting requested review from estelle estelle is a code owner automatically assigned from mdn/yari-content-css

Assignees
No one assigned
Labels
Content:Accessibility Accessibility docs Content:CSS Cascading Style Sheets docs Content:HTML Hypertext Markup Language docs Content:Other Any docs not covered by another "Content:" label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Define and add page-type for Web/Accessibility
2 participants
@teoli2003 @wbamberg