Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added caption to multimedia & embedding images doc #25400

Merged
merged 7 commits into from
Jun 15, 2023
Merged

Added caption to multimedia & embedding images doc #25400

merged 7 commits into from
Jun 15, 2023

Conversation

CBID2
Copy link
Contributor

@CBID2 CBID2 commented Mar 17, 2023

Description

I added a caption to the Multimedia & Embedding Images doc.

Motivation

It will make the doc more accessible.

Additional details

Related issues and pull requests

Relates to #115

@CBID2 CBID2 requested a review from a team as a code owner March 17, 2023 01:22
@CBID2 CBID2 requested review from schalkneethling and removed request for a team March 17, 2023 01:22
@github-actions github-actions bot added the Content:Learn Learning area docs label Mar 17, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 17, 2023

Preview URLs

(comment last updated: 2023-05-20 00:18:47)

Copy link
Contributor

@dawei-wang dawei-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

linting

…/index.md

Co-authored-by: dawei-wang <dawei-wang@users.noreply.github.com>
@CBID2
Copy link
Contributor Author

CBID2 commented Mar 17, 2023

linting

Still failed

@dawei-wang
Copy link
Contributor

linting

Still failed

Try again with the new suggestion

Co-authored-by: dawei-wang <dawei-wang@users.noreply.github.com>
@CBID2
Copy link
Contributor Author

CBID2 commented Mar 17, 2023

linting

Still failed

Try again with the new suggestion

It failed again

@CBID2 CBID2 requested a review from dawei-wang May 20, 2023 01:35
Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @CBID2 👍🏻

@bsmth bsmth merged commit 571eb77 into mdn:main Jun 15, 2023
@CBID2 CBID2 deleted the patch-2 branch June 15, 2023 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Learn Learning area docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants