Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use new SVG sidebar #25110

Merged
merged 1 commit into from
Mar 6, 2023
Merged

Use new SVG sidebar #25110

merged 1 commit into from
Mar 6, 2023

Conversation

wbamberg
Copy link
Collaborator

@wbamberg wbamberg commented Mar 6, 2023

Now we have a new SVG sidebar, let's use it in all the SVG docs.

@wbamberg wbamberg requested review from a team and Ryuno-Ki and removed request for a team March 6, 2023 17:42
@github-actions github-actions bot added the Content:SVG SVG docs label Mar 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2023

Preview URLs (31 pages)
Flaws (20)

Note! 26 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/SVG/Compatibility_sources
Title: Compatibility sources
Flaw count: 5

  • broken_links:
    • Can't resolve /en-US/docs/Web/SVG/SVG_1.1_Support_in_Firefox
    • Is currently http:// but can become https://
    • Is currently http:// but can become https://
    • Is currently http:// but can become https://
    • Is currently http:// but can become https://

URL: /en-US/docs/Web/SVG/Tutorial/SVG_In_HTML_Introduction
Title: SVG In HTML Introduction
Flaw count: 3

  • broken_links:
    • Can't resolve /en-US/docs/Web/accessibility/aria/role/img
    • Can't resolve /en-US/docs/Web/accessibility/aria/attributes/aria-labelledby
    • Can't resolve /en-US/docs/Web/accessibility/aria/attributes/aria-describedby

URL: /en-US/docs/Web/SVG/Element
Title: SVG element reference
Flaw count: 8

  • macros:
    • /en-US/docs/Web/SVG/Element/hatch does not exist
    • /en-US/docs/Web/SVG/Element/hatchpath does not exist
    • /en-US/docs/Web/SVG/Element/animateColor redirects to /en-US/docs/Web/SVG/Element/animate
    • /en-US/docs/Web/SVG/Element/hatch does not exist
    • /en-US/docs/Web/SVG/Element/hatch does not exist
    • and 3 more flaws omitted

URL: /en-US/docs/Web/SVG/Content_type
Title: Content type
Flaw count: 3

  • macros:
    • /en-US/docs/Web/API/SVGAnimatedAngle_objects does not exist
    • /en-US/docs/Web/API/SVGColor does not exist
    • /en-US/docs/Web/API/SVGPaint does not exist

URL: /en-US/docs/Web/SVG/Specification_Deviations
Title: Specification deviations
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/Gecko

hamishwillee
hamishwillee reviewed Mar 6, 2023
View reviewed changes
files/en-us/web/svg/applying_svg_effects_to_html_content/index.md
@@ -140,8 +146,10 @@ This demonstrates applying a filter to HTML content using SVG. It establishes se
<pre class="target">lorem</pre>
<p>
Lorem ipsum dolor sit amet, consectetur adipisicing
<em class="target">elit, sed do eiusmod tempor incididunt ut labore et dolore magna
aliqua.</em>
<em class="target"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hate prettier sometimes.

hamishwillee
hamishwillee reviewed Mar 6, 2023
View reviewed changes
files/en-us/web/svg/compatibility_sources/index.md
@@ -6,6 +6,8 @@ tags:
- SVG
---

{{SVGRef}}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has a sidebar but is not showing up in the sidebar

hamishwillee
hamishwillee reviewed Mar 6, 2023
View reviewed changes
files/en-us/web/svg/element/index.md
@@ -12,6 +12,8 @@ tags:
- "l10n:priority"
---

{{SVGRef}}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has sidebar but not highlighted in sidebar.

Also is "SVG element reference" a good name for this?

hamishwillee
hamishwillee reviewed Mar 6, 2023
View reviewed changes
files/en-us/web/svg/namespaces_crash_course/example/index.md
@@ -7,6 +7,8 @@ tags:
- XML
---

{{SVGRef}}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In sidebar but not highlighted in sidebar.

Also the title is "Example", would be good to have something more specific

hamishwillee
hamishwillee reviewed Mar 6, 2023
View reviewed changes
files/en-us/web/svg/scripting/index.md
@@ -12,6 +12,8 @@ tags:
- setProperty
---

{{SVGRef}}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has sidebar but not in sidebar

hamishwillee
hamishwillee reviewed Mar 6, 2023
View reviewed changes
files/en-us/web/svg/server-configuration/index.md
@@ -6,4 +6,6 @@ tags:
- SVG
---

{{SVGRef}}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has sidebar but no in sidebar. This topic is just a link - I wonder if it is needed at all.

hamishwillee
hamishwillee reviewed Mar 6, 2023
View reviewed changes
files/en-us/web/svg/specification_deviations/index.md
@@ -6,6 +6,8 @@ tags:
- SVG
---

{{SVGRef}}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has sidebar but not in sidebar

hamishwillee
hamishwillee reviewed Mar 6, 2023
View reviewed changes
files/en-us/web/svg/tutorial/svg_in_html_introduction/index.md
@@ -7,6 +7,8 @@ tags:
- SVG
---

{{SVGRef}}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has sidebar but not in sidebar

hamishwillee
hamishwillee reviewed Mar 6, 2023
View reviewed changes
files/en-us/web/svg/tutorial/index.md
@@ -11,6 +11,8 @@ tags:
- SVG:Tutorial
---

{{SVGRef}}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has sidebar, but not in sidebar

hamishwillee
hamishwillee approved these changes Mar 6, 2023
View reviewed changes
Copy link
Collaborator

@hamishwillee hamishwillee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are all "do what they say on the can", so I'm going to merge.

There are a bunch of cases where the pages are not actually in the sidebar - I've highlighted them for you to fix as a post process if you so wish.

@hamishwillee hamishwillee merged commit 2f34dad into mdn:main Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamishwillee hamishwillee hamishwillee approved these changes

@Ryuno-Ki Ryuno-Ki Awaiting requested review from Ryuno-Ki

Assignees
No one assigned
Labels
Content:SVG SVG docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wbamberg @hamishwillee