Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move pointerlock events to Element #20806

Merged
merged 1 commit into from
Sep 16, 2022
Merged

Conversation

Elchi3
Copy link
Member

@Elchi3 Elchi3 commented Sep 16, 2022

The compat tables are broken on
https://developer.mozilla.org/en-US/docs/Web/API/Document/pointerlockchange_event and
https://developer.mozilla.org/en-US/docs/Web/API/Document/pointerlockerror_event

The idea in the BCD PR mdn/browser-compat-data#16674 was to move these events to Element. Unfortunately, it was missed to move them (instead they were removed). I'm fixing this in BCD in mdn/browser-compat-data#17816.

This PR moves the event pages to Element as originally intended.

@Elchi3 Elchi3 requested review from a team as code owners September 16, 2022 15:46
@Elchi3 Elchi3 requested review from wbamberg and bsmth and removed request for a team September 16, 2022 15:46
@github-actions github-actions bot added Content:Other Any docs not covered by another "Content:" label Content:WebAPI Web API docs labels Sep 16, 2022
@github-actions
Copy link
Contributor

Preview URLs

Flaws

Note! 3 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/Events
Title: Event reference
Flaw count: 65

  • broken_links:
    • Can't resolve /en-US/docs/Web/API/Document/wheel_event
    • Can't resolve /en-US/docs/Web/API/Document/animationcancel_event
    • Can't resolve /en-US/docs/Web/API/Document/animationend_event
    • Can't resolve /en-US/docs/Web/API/Document/animationiteration_event
    • Can't resolve /en-US/docs/Web/API/Document/animationstart_event
    • and 60 more flaws omitted

URL: /en-US/docs/Web/API/Document
Title: Document
Flaw count: 55

  • macros:
    • /en-US/docs/Web/API/HTMLAllCollection does not exist
    • /en-US/docs/Web/API/Document/height redirects to /en-US/docs/Web/API/Element/clientHeight
    • /en-US/docs/Web/API/Document/width redirects to /en-US/docs/Web/API/Element/clientWidth
    • /en-US/docs/Web/API/Document/xmlStandalone does not exist
    • /en-US/docs/Web/API/Document/captureEvents does not exist
    • and 39 more flaws omitted
  • bad_bcd_links:
    • no explanation!
    • no explanation!
    • no explanation!
    • no explanation!
    • no explanation!
    • and 6 more flaws omitted

URL: /en-US/docs/Web/API/Element/pointerlockchange_event
Title: Element: pointerlockchange event
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: api.Element.pointerlockchange_event

URL: /en-US/docs/Web/API/Element/pointerlockerror_event
Title: Element: pointerlockerror event
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: api.Element.pointerlockerror_event

Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks @Elchi3 !

@wbamberg wbamberg merged commit 7fa657d into mdn:main Sep 16, 2022
@Elchi3 Elchi3 deleted the pointerlock-events branch September 16, 2022 19:16
Elchi3 added a commit that referenced this pull request Sep 19, 2022
bsmth pushed a commit that referenced this pull request Sep 19, 2022
himanshugarg pushed a commit to himanshugarg/content that referenced this pull request Sep 27, 2022
himanshugarg pushed a commit to himanshugarg/content that referenced this pull request Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Other Any docs not covered by another "Content:" label Content:WebAPI Web API docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants