Update dot concatenation of Express Tutorial Part 3 #20599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think it improves reading as is more easy view what happens, if the dot is before the word.
From line 451 to 453 is used the convention that I'm trying to add here.
example change from "
Athlete.
find().
where('sport').equals('Tennis')
"
to "
Athlete
.find()
.where('sport').equals('Tennis')
".
teoli2003
approved these changes
Sep 12, 2022
himanshugarg
pushed a commit
to himanshugarg/content
that referenced
this pull request
Sep 27, 2022
I think it improves reading as is more easy view what happens, if the dot is before the word.
From line 451 to 453 is used the convention that I'm trying to add here.
example change from "
Athlete.
find().
where('sport').equals('Tennis')
"
to "
Athlete
.find()
.where('sport').equals('Tennis')
".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it improves reading as is more easy view what happens, if the dot is before the word. From line 451 to 453 is used the convention that I'm trying to add here. example change from "
Athlete.
find().
where('sport').equals('Tennis')
"
to "
Athlete
.find()
.where('sport').equals('Tennis')
".
Description
Motivation
Additional details
Related issues and pull requests