adjust CODEOWNERS to reduce unnecessary reviews for core-dev team #20587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teoli2003
reviewed
Sep 12, 2022
| @@ -71,7 +71,7 @@ | |||
| # ---------------------------------------------------------------------------- | |||
| /.github/ @mdn/core-dev | |||
| /* @mdn/core-dev | |||
There was a problem hiding this comment.
You likely want to avoid being pinged for GroupData.json and other files at https://github.com/mdn/content/tree/main/files/jsondata as they have been moved from Yari to there to avoid requiring a review by a core-dev. 😄
There was a problem hiding this comment.
I believe this only matches files in the immediate root
caugner
approved these changes
Sep 12, 2022
dipikabh
approved these changes
Sep 12, 2022
Rumyra
approved these changes
Sep 12, 2022
himanshugarg
pushed a commit
to himanshugarg/content
that referenced
this pull request
Sep 27, 2022
…n#20587) Reduces review load for @mdn/core-dev.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For discussion: we're currently getting pinged for a lot of reviews which don't seem necessary - indeed, most PRs where core-dev is auto-assigned as a reviewer end up being merged without our review.
I've updated the default assignee for all file changes to the core-yari-content team - this seems more appropriate - and limited the core-dev reviews to only files changed in the immediate root of the repo (excluding markdown files) and in the
.githubfolder - even this may be a bit broad, but we can refine more in the future.Is this alright? Are there any files elsewhere we need to review before merging which may break the build?