Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML: remove deprecated <style type='text/css'> attribute #20577

Merged
merged 2 commits into from
Sep 12, 2022

Conversation

OnkarRuikar
Copy link
Contributor

The type attribute is deprecated on the <style> tag.
It defaults to text/css.

The PR removes remaining occurrences in the repo.

@OnkarRuikar OnkarRuikar requested a review from a team September 12, 2022 03:54
@OnkarRuikar OnkarRuikar requested review from a team as code owners September 12, 2022 03:54
@OnkarRuikar OnkarRuikar requested review from jpmedley and bsmth and removed request for a team September 12, 2022 03:54
@github-actions github-actions bot added Content:Other Any docs not covered by another "Content:" label Content:SVG SVG docs Content:WebAPI Web API docs labels Sep 12, 2022
@OnkarRuikar OnkarRuikar requested review from Josh-Cena and removed request for jpmedley and bsmth September 12, 2022 04:52
@OnkarRuikar
Copy link
Contributor Author

OnkarRuikar commented Sep 12, 2022

Just to confirm, we are not changing release docs for code lint issues as well right?

@Josh-Cena
Copy link
Member

That I think should be discussed case-by-case. I can't think of a general rule on top of my head—for example, we definitely want to add curly braces or normalize indentation, but code style would be more tricky.

@teoli2003 teoli2003 merged commit 457f4ed into mdn:main Sep 12, 2022
@OnkarRuikar OnkarRuikar deleted the remove_type_attr branch September 12, 2022 12:30
himanshugarg pushed a commit to himanshugarg/content that referenced this pull request Sep 27, 2022
* HTML: remove deprecated <style type='text/css'> attribute

* revert the change in release doc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Other Any docs not covered by another "Content:" label Content:SVG SVG docs Content:WebAPI Web API docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants