Remove deprecated methods from managing_screen_orientation #20295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The deprecated Screen.lockOrientation() method has been replaced with the ScreenOrientation.lock() method.
Preview URLsFlawsNone! 🎉 External URLsURL: No new external URLs (this comment was updated 2022-09-05 02:37:29.979911) |
files/en-us/web/api/css_object_model/managing_screen_orientation/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/css_object_model/managing_screen_orientation/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/css_object_model/managing_screen_orientation/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/css_object_model/managing_screen_orientation/index.md
Show resolved
Hide resolved
files/en-us/web/api/css_object_model/managing_screen_orientation/index.md
Show resolved
Hide resolved
sideshowbarker
approved these changes
Sep 5, 2022
|
Thanks much, and congrats on landing your first docs change here — welcome aboard 🎉 |
goshdarnheck
pushed a commit
to goshdarnheck/content
that referenced
this pull request
Sep 7, 2022
Co-authored-by: Michael[tm] Smith <mike@w3.org>
|
|
||
| ```js | ||
| screen.lockOrientation('landscape'); | ||
| {{domxref("ScreenOrientation.lock()", "screen.orientation.lock()")}} ; |
There was a problem hiding this comment.
Hey there! Just an after-review note, macros shouldn't be used inside of codeblocks like this -- the domxref in the above paragraph is sufficient to link to this method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The deprecated Screen.lockOrientation() method has been replaced with the ScreenOrientation.lock() method.
Summary
Deprecated Screen.lockOrientation() method has been replaced with Screen.unlockOrientation() method.
Motivation
Screen.lockOrientation() method is no longer used hence the article is misleading. This change will improve the article quality.
Supporting details
Related issues
Metadata