Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "lang" to <html> #19889

Merged
merged 1 commit into from
Aug 23, 2022
Merged

Add "lang" to <html> #19889

merged 1 commit into from
Aug 23, 2022

Conversation

rubiesonthesky
Copy link
Contributor

Summary

Adding lang attribute to element where it makes sense.

Also fixed some indentation and some other guideline issues in html / js code that I encountered.

Motivation

Supporting details

Related issues

Metadata

  • Adds a new document
  • Rewrites (or significantly expands) a document
  • Fixes a typo, bug, or other error

@rubiesonthesky rubiesonthesky requested review from a team as code owners August 23, 2022 20:09
@rubiesonthesky rubiesonthesky requested review from rebloor, jpmedley, teoli2003 and scottaohara and removed request for a team August 23, 2022 20:09
@github-actions github-actions bot added Content:Accessibility Accessibility docs Content:Learn Learning area docs Content:Other Any docs not covered by another "Content:" label Content:WebAPI Web API docs Content:WebExt WebExtensions docs labels Aug 23, 2022
@github-actions
Copy link
Contributor

Preview URLs

Flaws

Note! 19 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/Document_Object_Model/Introduction
Title: Introduction to the DOM
on GitHub
Flaw count: 1

  • macros:
    • /en-US/docs/Web/HTML/Element/h1 redirects to /en-US/docs/Web/HTML/Element/Heading_Elements

External URLs

URL: /en-US/docs/Web/Accessibility/Seizure_disorders
Title: Web accessibility for seizures and physical reactions
on GitHub

URL: /en-US/docs/Web/API/Document_Object_Model/Introduction
Title: Introduction to the DOM
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Document_object_model/Using_the_W3C_DOM_Level_1_Core
Title: Using the W3C DOM Level 1 Core
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Document_Object_Model/Traversing_an_HTML_table_with_JavaScript_and_DOM_Interfaces
Title: Traversing an HTML table with JavaScript and DOM Interfaces
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Document/getElementById
Title: Document.getElementById()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Document/write
Title: document.write()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Document/msCapsLockWarningOff
Title: Document.msCapsLockWarningOff
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Document/getElementsByTagNameNS
Title: Document.getElementsByTagNameNS()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Document/getElementsByClassName
Title: Document.getElementsByClassName()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Canvas_API/Tutorial/Drawing_shapes
Title: Drawing shapes with canvas
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Canvas_API/Tutorial/Using_images
Title: Using images
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/HTML_Drag_and_Drop_API/Multiple_items
Title: Dragging and Dropping Multiple Items
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/CSS_Object_Model/Using_dynamic_styling_information
Title: Using dynamic styling information
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Element/hasPointerCapture
Title: Element.hasPointerCapture()
on GitHub

No new external URLs

URL: /en-US/docs/Learn/Server-side/Django/web_application_security
Title: Django web application security
on GitHub

No new external URLs

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/Content_Security_Policy
Title: Content Security Policy
on GitHub

No new external URLs

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/Implement_a_settings_page
Title: Implement a settings page
on GitHub

No new external URLs

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/user_interface/Options_pages
Title: Options page
on GitHub

No new external URLs

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/Add_a_button_to_the_toolbar
Title: Add a button to the toolbar
on GitHub

No new external URLs

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/Working_with_the_Tabs_API
Title: Working with the Tabs API
on GitHub

No new external URLs

teoli2003
teoli2003 approved these changes Aug 23, 2022
View reviewed changes
Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@teoli2003 teoli2003 merged commit abb4596 into mdn:main Aug 23, 2022
@rubiesonthesky rubiesonthesky deleted the html-add-lang-attribute branch August 23, 2022 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teoli2003 teoli2003 teoli2003 approved these changes

@rebloor rebloor Awaiting requested review from rebloor rebloor is a code owner automatically assigned from mdn/yari-content-mozilla-add-ons

@jpmedley jpmedley Awaiting requested review from jpmedley jpmedley is a code owner automatically assigned from mdn/yari-content-web-api

@scottaohara scottaohara Awaiting requested review from scottaohara scottaohara is a code owner automatically assigned from mdn/yari-content-accessibility

Assignees
No one assigned
Labels
Content:Accessibility Accessibility docs Content:Learn Learning area docs Content:Other Any docs not covered by another "Content:" label Content:WebAPI Web API docs Content:WebExt WebExtensions docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rubiesonthesky @teoli2003