Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove GlobalEventHandlers (and almost all mentions of it) from MDN #18778

Merged
merged 3 commits into from
Aug 8, 2022
Merged

Remove GlobalEventHandlers (and almost all mentions of it) from MDN #18778

merged 3 commits into from
Aug 8, 2022

Conversation

queengooborg
Copy link
Collaborator

@queengooborg queengooborg commented Jul 25, 2022

This PR removes the GlobalEventHandlers mixin, as well as (almost) all mentions of it throughout MDN. A side effect of this is fixing a lot of broken links left behind from the events conversion.

Note: there are still a lot of leftover links on individual event pages. These will be fixed in #18732 and #18779.

@queengooborg queengooborg requested review from a team as code owners July 25, 2022 12:49
@queengooborg queengooborg requested review from jpmedley, Josh-Cena, schalkneethling and Rumyra and removed request for a team July 25, 2022 12:49
@github-actions github-actions bot added Content:Accessibility Accessibility docs Content:HTML Hypertext Markup Language docs Content:Learn Learning area docs Content:MathML MathML docs Content:Other Any docs not covered by another "Content:" label Content:WebAPI Web API docs labels Jul 25, 2022
@github-actions

This comment was marked as resolved.

Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A first question here, before I review this in detail.

Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@teoli2003 teoli2003 merged commit 548d15d into mdn:main Aug 8, 2022
@teoli2003
Copy link
Contributor

🍾

@queengooborg queengooborg deleted the GlobalEventHandlers branch August 8, 2022 05:35
@queengooborg
Copy link
Collaborator Author

Whoo! This officially marks the completion of two big OWD projects! 🎉🎊🍾

yin1999 added a commit to yin1999/translated-content that referenced this pull request Sep 1, 2022
yin1999 added a commit to mdn/translated-content that referenced this pull request Sep 1, 2022
* delete for each...in error page

ref: mdn/content#10793

* delete a TypeError page

* Removed obsolete page: sniffing animation support

ref: mdn/content#17290

* Duplicate Page Delete

ref: mdn/content#17765

* Delete Glossary/DHTML

ref: mdn/content#13138

* remove GlobalEventHandlers

ref: mdn/content#18778

* cleanup wikihistory
yin1999 added a commit to yin1999/translated-content that referenced this pull request Sep 3, 2022
yin1999 added a commit to mdn/translated-content that referenced this pull request Sep 3, 2022
* remove XMLHttpRequest.mozResponseArrayBuffer

* Remove Firefox internal canvas.drawWidgetAsOnScreen page

ref: mdn/content#19706

* Remove api.Document.documentURIObject

ref: mdn/content#7489

* Remove non-standard no-more-implemented children of File

ref: mdn/content#8928

* Remove irrelevant FileError API

ref: mdn/content#8166

* Remove PerformanceFrameTiming from MDN

ref: mdn/content#9670

* Remove GlobalEventHandlers

ref: mdn/content#18778

* Remove sync version of IDB API which never existed

ref: mdn/content#13139

* Remove api.Text.isElementContentWhitespace

ref: mdn/content#7488

* Delete TextRange

ref: mdn/content#8589

* Remove UIEvent.isChar documentation

ref: mdn/content#8350

* delete window.controllers

ref: mdn/content#8408

* Remove Window.dialogArguments from MDN

ref: mdn/content#15754

* delete window.directories

ref: mdn/content#8405

* remove Window.{onmozbeforepaint, onpaint}

ref: mdn/content#8244

* Remove Window.setCursor page

ref: mdn/content#10694

* cleanup wikihistory
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Accessibility Accessibility docs Content:HTML Hypertext Markup Language docs Content:Learn Learning area docs Content:MathML MathML docs Content:Other Any docs not covered by another "Content:" label Content:WebAPI Web API docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants