-
Notifications
You must be signed in to change notification settings - Fork 22.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ABBR: remove title #18409
ABBR: remove title #18409
Conversation
Preview URLs
FlawsNote! 5 documents with no flaws that don't need to be listed. 🎉 URL:
URL:
URL:
URL:
URL:
URL:
External URLsURL: No new external URLs URL: No new external URLs URL: No new external URLs URL:
URL: No new external URLs URL: No new external URLs URL: No new external URLs URL: No new external URLs URL: No new external URLs URL: No new external URLs URL: No new external URLs (this comment was updated 2022-07-19 20:30:33.192262) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! A few nits and some questions!
files/en-us/learn/html/introduction_to_html/advanced_text_formatting/index.md
Outdated
Show resolved
Hide resolved
@@ -525,7 +527,7 @@ solution.addEventListener('click', function() { | |||
updateCode(); | |||
}); | |||
|
|||
const htmlSolution = '<p><abbr title="National Aeronautics and Space Administration">NASA</abbr> sure does some exciting work.</p>'; | |||
const htmlSolution = '<p><abbr>NASA</abbr>, the National Aeronautics and Space Administration, sure does some exciting work.</p>'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm curious, will screen readers read this as N – A – S – A or as Nasa?
If they do the first, how should we mark up our content to prevent this?
@@ -10,9 +10,9 @@ tags: | |||
- States | |||
- Properties | |||
--- | |||
This page lists reference pages covering all the WAI-ARIA attributes discussed on MDN. | |||
This page lists reference pages covering all the <abbr>WAI-ARIA</abbr> attributes discussed on <abbr>MDN</abbr>. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Strictly speaking, MDN is no more an abbreviation for Mozilla Developer Network, like IBM is no more an abbreviation for International Business Machines.
Additional semantics are attached to the `title` attributes of the {{HTMLElement("link")}}, {{HTMLElement("abbr")}}, {{HTMLElement("input")}}, and {{HTMLElement("menuitem")}} elements. | ||
The `title` attribute, when added to [`<link rel="stylesheet">`](/en-US/docs/Web/HTML/Element/link), creates an alternate stylesheet. When defining an alternative style sheet with `<link rel="alternate">` the attribute is required and must be set to a non-empty string. | ||
|
||
While `title` can be used to provide a programmatically associated label for an {{HTMLElement("input")}} element, this is not good practice. Use a {{HTMLElement("label")}} instead. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should list the <abbr>
case here, too.
Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Summary
The
title
attribute is not recommended on ABBR. See https://www.tpgi.com/short-note-the-abbreviation-appreciation-society/, but can be used when an expansion of the abbreviation for all users to see is not possible. It is NOT needed when the acronym is obvious, such as on the MDN acronym on MDN.The
title
attribute page was missing some features (LINK element), incorrect in some areas (should not be used on INPUT), and referenced deprecated elements (MENUITEM), so I edited that page a little more in-depth.*
for required is not an abbreviation or acronym. Edited that.Motivation
Supporting details
https://www.tpgi.com/short-note-the-abbreviation-appreciation-society/
Related issues
PArt of openwebdocs/project#115
Metadata