Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demix scroll event from GlobalEventHandlers #18314

Merged
merged 2 commits into from
Jul 14, 2022
Merged

Demix scroll event from GlobalEventHandlers #18314

merged 2 commits into from
Jul 14, 2022

Conversation

queengooborg
Copy link
Collaborator

@queengooborg queengooborg commented Jul 13, 2022

This PR demixes the onscroll event handler from the GlobalEventHandlers mixin. Related BCD PR: mdn/browser-compat-data#16727

@queengooborg queengooborg requested review from a team as code owners July 13, 2022 12:48
@queengooborg queengooborg requested review from wbamberg and removed request for a team July 13, 2022 12:48
@github-actions github-actions bot added the Content:WebAPI Web API docs label Jul 13, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jul 13, 2022

Preview URLs

Flaws

Note! 2 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/Window
Title: Window
on GitHub
Flaw count: 51

  • macros:
    • /en-US/docs/Web/API/Window/messageManager does not exist
    • /en-US/docs/Web/API/Window/performance redirects to /en-US/docs/Web/API/performance_property
    • /en-US/docs/Web/API/Window/returnValue does not exist
    • /en-US/docs/Web/API/Window/setResizable does not exist
    • /en-US/docs/Web/API/Window/home does not exist
    • and 34 more flaws omitted
  • broken_links:
    • Can't resolve /en-US/docs/The_message_manager
  • bad_bcd_links:
    • no explanation!
    • no explanation!
    • no explanation!
    • no explanation!
    • no explanation!
    • and 6 more flaws omitted

URL: /en-US/docs/Web/API/Element
Title: Element
on GitHub
Flaw count: 28

  • macros:
    • /en-US/docs/Web/API/Element/getBoxQuads does not exist
    • /en-US/docs/Web/API/GlobalEventHandlers/oncancel does not exist
    • /en-US/docs/Web/API/Element/select_event redirects to /en-US/docs/Web/API/HTMLInputElement/select_event
    • /en-US/docs/Web/API/GlobalEventHandlers/onshow does not exist
    • /en-US/docs/Web/API/HTMLElement/oncopy redirects to /en-US/docs/Web/API/HTMLElement/copy_event
    • and 22 more flaws omitted
  • bad_bcd_links:
    • no explanation!

URL: /en-US/docs/Web/API/GlobalEventHandlers
Title: GlobalEventHandlers
on GitHub
Flaw count: 75

  • macros:
    • /en-US/docs/Web/API/GlobalEventHandlers/onabort redirects to /en-US/docs/Web/API/HTMLMediaElement/abort_event
    • /en-US/docs/Web/API/GlobalEventHandlers/oncontextmenu redirects to /en-US/docs/Web/API/Element/contextmenu_event
    • /en-US/docs/Web/API/GlobalEventHandlers/onformdata redirects to /en-US/docs/Web/API/HTMLFormElement/formdata_event
    • /en-US/docs/Web/API/HTMLMediaElement/loadend_event does not exist
    • /en-US/docs/Web/API/GlobalEventHandlers/onprogress does not exist
    • and 9 more flaws omitted
  • bad_bcd_links:
    • no explanation!
    • no explanation!
    • no explanation!
    • no explanation!
    • no explanation!
    • and 56 more flaws omitted

URL: /en-US/docs/Web/API/Document
Title: Document
on GitHub
Flaw count: 67

  • macros:
    • /en-US/docs/Web/API/HTMLAllCollection does not exist
    • /en-US/docs/Web/API/Document/xmlStandalone does not exist
    • /en-US/docs/Web/API/Document/captureEvents does not exist
    • /en-US/docs/Web/API/Document/getBoxQuads does not exist
    • /en-US/docs/Web/API/Document/normalizeDocument does not exist
    • and 38 more flaws omitted
  • bad_bcd_links:
    • no explanation!
    • no explanation!
    • no explanation!
    • no explanation!
    • no explanation!
    • and 19 more flaws omitted

External URLs

URL: /en-US/docs/Web/API/Window
Title: Window
on GitHub


URL: /en-US/docs/Web/API/Element
Title: Element
on GitHub


URL: /en-US/docs/Web/API/Element/scroll_event
Title: Element: scroll event
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/GlobalEventHandlers
Title: GlobalEventHandlers
on GitHub

No external URLs


URL: /en-US/docs/Web/API/Document
Title: Document
on GitHub


URL: /en-US/docs/Web/API/Document/scroll_event
Title: Document: scroll event
on GitHub

No new external URLs

(this comment was updated 2022-07-14 13:25:46.827882)

Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@teoli2003
Copy link
Contributor

There is a merge conflict.

@queengooborg queengooborg merged commit ddf7070 into mdn:main Jul 14, 2022
@queengooborg queengooborg deleted the onscroll branch July 14, 2022 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants