Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demix pointer events from GlobalEventHandlers #18228

Merged
merged 2 commits into from
Jul 11, 2022
Merged

Demix pointer events from GlobalEventHandlers #18228

merged 2 commits into from
Jul 11, 2022

Conversation

queengooborg
Copy link
Collaborator

This PR demixes the onpointer* event handlers from the GlobalEventHandlers mixin. Additionally, this PR moves the events from the HTMLElement to Element to better indicate the event target. Related BCD PR: mdn/browser-compat-data#16674

@queengooborg queengooborg requested review from a team as code owners July 11, 2022 14:54
@queengooborg queengooborg requested review from sideshowbarker and removed request for a team July 11, 2022 14:54
@github-actions github-actions bot added the Content:WebAPI Web API docs label Jul 11, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jul 11, 2022

Preview URLs

Flaws

Note! 1 document with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/Element/pointerenter_event
Title: Element: pointerenter event
on GitHub
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: api.Element.pointerenter_event

URL: /en-US/docs/Web/API/Element/pointerleave_event
Title: Element: pointerleave event
on GitHub
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: api.Element.pointerleave_event

URL: /en-US/docs/Web/API/Element/pointermove_event
Title: Element: pointermove event
on GitHub
Flaw count: 2

  • broken_links:
    • Link points to the page it's already on
  • bad_bcd_queries:
    • No BCD data for query: api.Element.pointermove_event

URL: /en-US/docs/Web/API/Element/pointercancel_event
Title: Element: pointercancel event
on GitHub
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: api.Element.pointercancel_event

URL: /en-US/docs/Web/API/Element/pointerdown_event
Title: Element: pointerdown event
on GitHub
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: api.Element.pointerdown_event

URL: /en-US/docs/Web/API/Element/pointerover_event
Title: Element: pointerover event
on GitHub
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: api.Element.pointerover_event

URL: /en-US/docs/Web/API/Element/pointerup_event
Title: Element: pointerup event
on GitHub
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: api.Element.pointerup_event

URL: /en-US/docs/Web/API/Element/pointerout_event
Title: Element: pointerout event
on GitHub
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: api.Element.pointerout_event

URL: /en-US/docs/Web/API/GlobalEventHandlers
Title: GlobalEventHandlers
on GitHub
Flaw count: 56

  • macros:
    • /en-US/docs/Web/API/GlobalEventHandlers/onabort redirects to /en-US/docs/Web/API/HTMLMediaElement/abort_event
    • /en-US/docs/Web/API/GlobalEventHandlers/oncontextmenu redirects to /en-US/docs/Web/API/Element/contextmenu_event
    • /en-US/docs/Web/API/GlobalEventHandlers/onformdata redirects to /en-US/docs/Web/API/HTMLFormElement/formdata_event
    • /en-US/docs/Web/API/HTMLMediaElement/loadend_event does not exist
    • /en-US/docs/Web/API/GlobalEventHandlers/onprogress does not exist
    • and 11 more flaws omitted
  • bad_bcd_links:
    • no explanation!
    • no explanation!
    • no explanation!
    • no explanation!
    • no explanation!
    • and 35 more flaws omitted

URL: /en-US/docs/Web/API/HTMLElement
Title: HTMLElement
on GitHub
Flaw count: 36

  • macros:
    • /en-US/docs/Web/API/HTMLElement/attributeStyleMap does not exist
    • /en-US/docs/Web/API/HTMLElement/draggable does not exist
    • /en-US/docs/Web/API/HTMLElement/noModule does not exist
    • /en-US/docs/Web/API/HTMLElement/properties does not exist
    • /en-US/docs/Web/API/HTMLPropertiesCollection does not exist
    • and 17 more flaws omitted
  • bad_bcd_links:
    • no explanation!
    • no explanation!
    • no explanation!
    • no explanation!
    • no explanation!
    • and 9 more flaws omitted

URL: /en-US/docs/Web/API/Document
Title: Document
on GitHub
Flaw count: 35

  • macros:
    • /en-US/docs/Web/API/HTMLAllCollection does not exist
    • /en-US/docs/Web/API/Document/xmlStandalone does not exist
    • /en-US/docs/Web/API/Document/captureEvents does not exist
    • /en-US/docs/Web/API/Document/getBoxQuads does not exist
    • /en-US/docs/Web/API/Document/normalizeDocument does not exist
    • and 15 more flaws omitted
  • bad_bcd_links:
    • no explanation!
    • no explanation!
    • no explanation!
    • no explanation!
    • no explanation!
    • and 10 more flaws omitted

URL: /en-US/docs/Web/API/Document/pointerenter_event
Title: Document: pointerenter event
on GitHub
Flaw count: 1

  • macros:
    • /en-US/docs/Web/API/HTMLElement/pointerenter_event redirects to /en-US/docs/Web/API/Element/pointerenter_event

URL: /en-US/docs/Web/API/Document/pointerleave_event
Title: Document: pointerleave event
on GitHub
Flaw count: 1

  • macros:
    • /en-US/docs/Web/API/HTMLElement/pointerleave_event redirects to /en-US/docs/Web/API/Element/pointerleave_event

URL: /en-US/docs/Web/API/Document/pointermove_event
Title: Document: pointermove event
on GitHub
Flaw count: 2

  • macros:
    • /en-US/docs/Web/API/HTMLElement/pointermove_event redirects to /en-US/docs/Web/API/Element/pointermove_event
  • broken_links:
    • Can't resolve /en-US/docs/Web/API/HTMLElement/pointercancel_event

URL: /en-US/docs/Web/API/Document/pointerdown_event
Title: Document: pointerdown event
on GitHub
Flaw count: 1

  • macros:
    • /en-US/docs/Web/API/HTMLElement/pointerdown_event redirects to /en-US/docs/Web/API/Element/pointerdown_event

URL: /en-US/docs/Web/API/Document/pointerover_event
Title: Document: pointerover event
on GitHub
Flaw count: 1

  • macros:
    • /en-US/docs/Web/API/HTMLElement/pointerover_event redirects to /en-US/docs/Web/API/Element/pointerover_event

URL: /en-US/docs/Web/API/Document/pointerup_event
Title: Document: pointerup event
on GitHub
Flaw count: 1

  • macros:
    • /en-US/docs/Web/API/HTMLElement/pointerup_event redirects to /en-US/docs/Web/API/Element/pointerup_event

URL: /en-US/docs/Web/API/Document/pointerout_event
Title: Document: pointerout event
on GitHub
Flaw count: 1

  • macros:
    • /en-US/docs/Web/API/HTMLElement/pointerout_event redirects to /en-US/docs/Web/API/Element/pointerout_event

URL: /en-US/docs/Web/API/PointerEvent
Title: PointerEvent
on GitHub
Flaw count: 11

  • macros:
    • /en-US/docs/Web/API/HTMLElement/pointermove_event redirects to /en-US/docs/Web/API/Element/pointermove_event
    • /en-US/docs/Web/API/PointerEvent/getPredictedEvents does not exist
    • /en-US/docs/Web/API/HTMLElement/pointermove_event redirects to /en-US/docs/Web/API/Element/pointermove_event
    • /en-US/docs/Web/API/HTMLElement/pointerover_event redirects to /en-US/docs/Web/API/Element/pointerover_event
    • /en-US/docs/Web/API/HTMLElement/pointerenter_event redirects to /en-US/docs/Web/API/Element/pointerenter_event
    • and 6 more flaws omitted

URL: /en-US/docs/Web/API/Pointer_events
Title: Pointer events
on GitHub
Flaw count: 2

  • macros:
    • /en-US/docs/Web/API/Element/gotpointercapture_event redirects to /en-US/docs/Web/API/HTMLElement/gotpointercapture_event
    • /en-US/docs/Web/API/Element/lostpointercapture_event redirects to /en-US/docs/Web/API/HTMLElement/lostpointercapture_event

External URLs

URL: /en-US/docs/Web/API/Element/pointerenter_event
Title: Element: pointerenter event
on GitHub


URL: /en-US/docs/Web/API/Element/pointerleave_event
Title: Element: pointerleave event
on GitHub


URL: /en-US/docs/Web/API/Element/pointermove_event
Title: Element: pointermove event
on GitHub


URL: /en-US/docs/Web/API/Element/pointercancel_event
Title: Element: pointercancel event
on GitHub


URL: /en-US/docs/Web/API/Element/pointerdown_event
Title: Element: pointerdown event
on GitHub


URL: /en-US/docs/Web/API/Element/pointerover_event
Title: Element: pointerover event
on GitHub


URL: /en-US/docs/Web/API/Element/pointerup_event
Title: Element: pointerup event
on GitHub


URL: /en-US/docs/Web/API/Element/pointerout_event
Title: Element: pointerout event
on GitHub


URL: /en-US/docs/Web/API/GlobalEventHandlers
Title: GlobalEventHandlers
on GitHub

No external URLs


URL: /en-US/docs/Web/API/HTMLElement
Title: HTMLElement
on GitHub

No external URLs


URL: /en-US/docs/Web/API/Document
Title: Document
on GitHub


URL: /en-US/docs/Web/API/Document/pointerenter_event
Title: Document: pointerenter event
on GitHub


URL: /en-US/docs/Web/API/Document/pointerleave_event
Title: Document: pointerleave event
on GitHub


URL: /en-US/docs/Web/API/Document/pointermove_event
Title: Document: pointermove event
on GitHub


URL: /en-US/docs/Web/API/Document/pointercancel_event
Title: Document: pointercancel event
on GitHub


URL: /en-US/docs/Web/API/Document/pointerdown_event
Title: Document: pointerdown event
on GitHub


URL: /en-US/docs/Web/API/Document/pointerover_event
Title: Document: pointerover event
on GitHub


URL: /en-US/docs/Web/API/Document/pointerup_event
Title: Document: pointerup event
on GitHub


URL: /en-US/docs/Web/API/Document/pointerout_event
Title: Document: pointerout event
on GitHub


URL: /en-US/docs/Web/API/PointerEvent
Title: PointerEvent
on GitHub


URL: /en-US/docs/Web/API/Pointer_events
Title: Pointer events
on GitHub

No new external URLs

(this comment was updated 2022-07-11 18:39:22.216049)

Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@teoli2003
Copy link
Contributor

Some conflicts to solve and this can land.

@teoli2003 teoli2003 merged commit a16df95 into mdn:main Jul 11, 2022
@queengooborg queengooborg deleted the onpointer branch July 11, 2022 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants