Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Demix onselectstart/onselectionchange from GlobalEventHandlers #18106

Merged
merged 9 commits into from
Jul 12, 2022
Merged

Demix onselectstart/onselectionchange from GlobalEventHandlers #18106

merged 9 commits into from
Jul 12, 2022

Conversation

queengooborg
Copy link
Collaborator

This PR demixes the onselectstart and onselectionchange event handlers from the GlobalEventHandlers mixin. Related BCD PR: mdn/browser-compat-data#16359

@queengooborg queengooborg requested review from a team as code owners July 8, 2022 05:13
@queengooborg queengooborg requested review from wbamberg and removed request for a team July 8, 2022 05:13
@github-actions github-actions bot added Content:Other Any docs not covered by another "Content:" label Content:WebAPI Web API docs labels Jul 8, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2022 •
edited
Loading

Preview URLs

Flaws

Note! 4 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/GlobalEventHandlers
Title: GlobalEventHandlers
on GitHub
Flaw count: 52

  • macros:
    • /en-US/docs/Web/API/GlobalEventHandlers/onabort redirects to /en-US/docs/Web/API/HTMLMediaElement/abort_event
    • /en-US/docs/Web/API/GlobalEventHandlers/oncontextmenu redirects to /en-US/docs/Web/API/Element/contextmenu_event
    • /en-US/docs/Web/API/GlobalEventHandlers/onformdata redirects to /en-US/docs/Web/API/HTMLFormElement/formdata_event
    • /en-US/docs/Web/API/HTMLMediaElement/loadend_event does not exist
    • /en-US/docs/Web/API/GlobalEventHandlers/onpointerlockchange does not exist
    • and 13 more flaws omitted
  • bad_bcd_links:
    • no explanation!
    • no explanation!
    • no explanation!
    • no explanation!
    • no explanation!
    • and 29 more flaws omitted

URL: /en-US/docs/Web/API/Document
Title: Document
on GitHub
Flaw count: 38

  • macros:
    • /en-US/docs/Web/API/HTMLAllCollection does not exist
    • /en-US/docs/Web/API/Document/xmlStandalone does not exist
    • /en-US/docs/Web/API/Document/captureEvents does not exist
    • /en-US/docs/Web/API/Document/getBoxQuads does not exist
    • /en-US/docs/Web/API/Document/normalizeDocument does not exist
    • and 18 more flaws omitted
  • bad_bcd_links:
    • no explanation!
    • no explanation!
    • no explanation!
    • no explanation!
    • no explanation!
    • and 10 more flaws omitted

URL: /en-US/docs/Web/API/Window
Title: Window
on GitHub
Flaw count: 29

  • macros:
    • /en-US/docs/Web/API/Window/messageManager does not exist
    • /en-US/docs/Web/API/Window/performance redirects to /en-US/docs/Web/API/performance_property
    • /en-US/docs/Web/API/Window/returnValue does not exist
    • /en-US/docs/Web/API/Window/setResizable does not exist
    • /en-US/docs/Web/API/Window/home does not exist
    • and 20 more flaws omitted
  • broken_links:
    • Can't resolve /en-US/docs/The_message_manager
  • bad_bcd_links:
    • no explanation!
    • no explanation!
    • no explanation!

URL: /en-US/docs/Mozilla/Firefox/Releases/52
Title: Firefox 52 for developers
on GitHub
Flaw count: 2

  • macros:
    • /en-US/docs/Web/API/Window/appinstalled does not exist
    • /en-US/docs/Web/API/HTMLMediaElement/loadend_event does not exist

URL: /en-US/docs/Mozilla/Firefox/Releases/43
Title: Firefox 43 for developers
on GitHub
Flaw count: 9

  • macros:
    • /en-US/docs/Web/API/PerformanceRenderTiming does not exist
    • /en-US/docs/Web/API/PerformanceCompositeTiming does not exist
    • /en-US/docs/Web/API/Screen/mozOrientation does not exist
    • /en-US/docs/Web/API/Screen/onmozorientationchange does not exist
    • /en-US/docs/Web/API/Screen/mozLockOrientation does not exist
    • and 3 more flaws omitted
  • broken_links:
    • Can't resolve /en-US/docs/Web/API/Performance_Timeline_API

External URLs

URL: /en-US/docs/Web/API/GlobalEventHandlers
Title: GlobalEventHandlers
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/HTMLTextAreaElement/selectionchange_event
Title: HTMLTextAreaElement: selectionchange event
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/HTMLInputElement/selectionchange_event
Title: HTMLInputElement: selectionchange event
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Document
Title: Document
on GitHub

URL: /en-US/docs/Web/API/Document/selectstart_event
Title: Document: selectstart event
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Document/selectionchange_event
Title: Document: selectionchange event
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Window
Title: Window
on GitHub

URL: /en-US/docs/Mozilla/Firefox/Releases/52
Title: Firefox 52 for developers
on GitHub

No new external URLs

URL: /en-US/docs/Mozilla/Firefox/Releases/43
Title: Firefox 43 for developers
on GitHub

No new external URLs

(this comment was updated 2022-07-11 17:15:50.808623)

teoli2003
teoli2003 suggested changes Jul 8, 2022
View reviewed changes
Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the moment I have a few questions to help my understanding here.

Once they are answered I will do a formal review. Marking as Request changes so that I don't merge by error meanwhile.

foolip
foolip reviewed Jul 9, 2022
View reviewed changes
files/en-us/_redirects.txt Outdated
@@ -8147,6 +8147,8 @@
/en-US/docs/Web/API/GlobalEventHandlers/onpointerdown/drag /en-US/docs/Web/API/GlobalEventHandlers/ondrag
/en-US/docs/Web/API/GlobalEventHandlers/onreset /en-US/docs/Web/API/HTMLFormElement/reset_event
/en-US/docs/Web/API/GlobalEventHandlers/onresize /en-US/docs/Web/API/Window/resize_event
/en-US/docs/Web/API/GlobalEventHandlers/onselectionchange /en-US/docs/Web/API/Document/selectionchange_event
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest redirecting to the event on Element, that'll be the most common one people deal with.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, wait, I thought I was commenting on the securitypolicyviolation event here. For selectionchange I don't know.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pointed it to HTMLInputElement, which seems like the most likely interface that users would want to check out!

@teoli2003 teoli2003 merged commit c4a9661 into mdn:main Jul 12, 2022
@queengooborg queengooborg deleted the onselect branch July 12, 2022 06:03
@Elchi3 Elchi3 mentioned this pull request Sep 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@foolip foolip foolip left review comments

@teoli2003 teoli2003 teoli2003 approved these changes

@wbamberg wbamberg Awaiting requested review from wbamberg wbamberg is a code owner automatically assigned from mdn/yari-content-web-api

Assignees
No one assigned
Labels
Content:Other Any docs not covered by another "Content:" label Content:WebAPI Web API docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@queengooborg @foolip @teoli2003