Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CanvasImageSource typedef #17181

Merged
merged 3 commits into from
Jun 13, 2022
Merged

Remove CanvasImageSource typedef #17181

merged 3 commits into from
Jun 13, 2022

Conversation

teoli2003
Copy link
Contributor

This PR gets rid of all mentions of CanvasImageSource.

There are two rationales behind this:

  1. Typedef names are not visible in the Web console, or to Web developers, they are artifacts of the spec, to simplify it. From the Web dev perspective, they add complexity
  2. As part of the page-type project ([page types] Define page types for Web/API #16255), we don't want to have a special page type for these typedef-like pages. It is necessary to deal with it now.

@teoli2003 teoli2003 requested review from a team as code owners June 11, 2022 05:50
@teoli2003 teoli2003 requested review from a team, Rumyra and Guyzeroth and removed request for a team June 11, 2022 05:50
@github-actions github-actions bot added Content:Other Any docs not covered by another "Content:" label Content:WebAPI Web API docs labels Jun 11, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jun 11, 2022

Preview URLs

Flaws

Note! 8 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/VideoFrame
Title: VideoFrame
on GitHub
Flaw count: 1

  • macros:
    • /en-US/docs/Web/API/Web_Codecs_API does not exist

URL: /en-US/docs/Web/API/VideoFrame/VideoFrame
Title: VideoFrame.VideoFrame()
on GitHub
Flaw count: 2

  • macros:
    • /en-US/docs/Web/API/ArrayBuffer does not exist
    • /en-US/docs/Web/API/ArrayBuffer does not exist

URL: /en-US/docs/Mozilla/Firefox/Releases/56
Title: Firefox 56 for developers
on GitHub
Flaw count: 5

  • macros:
    • /en-US/docs/Web/API/Document/onvisibilitychange redirects to /en-US/docs/Web/API/Document/visibilitychange_event
    • /en-US/docs/Web/API/HTMLInputElement/formAction does not exist
    • /en-US/docs/Web/API/HTMLButtonElement/formAction does not exist
    • /en-US/docs/Web/HTML/Element/isindex does not exist
  • broken_links:
    • Can't resolve /en-US/docs/Mozilla/Firefox/Headless_mode

External URLs

URL: /en-US/docs/Web/API/Barcode_Detection_API
Title: Barcode Detection API
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/Canvas_API
Title: Canvas API
on GitHub


URL: /en-US/docs/Web/API/Canvas_API/Tutorial/Applying_styles_and_colors
Title: Applying styles and colors
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/Canvas_API/Tutorial/Using_images
Title: Using images
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/BarcodeDetector/BarcodeDetector
Title: BarcodeDetector()
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/CanvasRenderingContext2D
Title: CanvasRenderingContext2D
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/CanvasRenderingContext2D/drawImage
Title: CanvasRenderingContext2D.drawImage()
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/CanvasRenderingContext2D/createPattern
Title: CanvasRenderingContext2D.createPattern()
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/VideoFrame
Title: VideoFrame
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/VideoFrame/VideoFrame
Title: VideoFrame.VideoFrame()
on GitHub

No new external URLs


URL: /en-US/docs/Mozilla/Firefox/Releases/56
Title: Firefox 56 for developers
on GitHub

No new external URLs

(this comment was updated 2022-06-11 06:06:57.174815)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Other Any docs not covered by another "Content:" label Content:WebAPI Web API docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants