-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete DOMTimestamp and EpochTimestamp #17096
Conversation
Preview URLs (17 pages)
Flaws (53)Note! 11 documents with no flaws that don't need to be listed. 🎉 URL:
URL:
URL:
URL:
URL:
URL:
External URLs (2)URL:
(this comment was updated 2022-11-15 01:08:40.831579) |
This pull request has merge conflicts that must be resolved before it can be merged. |
@teoli2003 This needs a rebase and remaining fixes. Would be great to get in. |
@hamishwillee , I think @Elchi3 and I are going to have to take care of this anyway as part of the work on the Performance API: openwebdocs/project#62. |
Many typedefs probably need no page in the Web/API/ reference. Some (like these two) probably need a glossary page or some docs somewhere. It would be nice to have a plan about typedefs generally. I opened a discussion: mdn/mdn-community#282 |
@wbamberg Re https://github.com/orgs/mdn/discussions/282#discussioncomment-4141217
See the note in DOMTimeStamp: So yes, it has been removed and renamed in one spec, but it still gets reference in others. Lazy Hamish says it probably doesn't matter all that much - ie. those other specs are not all that important. But I have not done the investigation. |
I've fixed the merge conflicts here and made the changes I recommended in my own review :). So this PR now does three things:
After this there are no references to This doesn't yet tackle |
Co-authored-by: Hamish Willee <hamishwillee@gmail.com>
the `GeolocationCoordinates` object is part of the | ||
{{domxref("GeolocationPosition")}} interface, which is the object type returned by | ||
Geolocation API functions that obtain and return a geographical position. | ||
The {{domxref("GeolocationCoordinates")}} interface's read-only **`longitude`** property is a double-precision floating point value which represents the longitude of a geographical position, specified in decimal degrees. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps not relevant to this change, but does it matter that it is double-precision floating point? Isn't it just a number in JavaScript
* origin/EpochTimestamp: tidying layout
files/en-us/web/api/serviceworkerregistration/shownotification/index.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent. Just a couple of comments. If you either respond or mark those resolved I am happy to merge (or for you to).
notification is actual. For example, this could be in the past when a notification | ||
is used for a message that couldn't immediately be delivered because the device | ||
was offline, or in the future for a meeting that is about to start. | ||
- : A timestamp, given as [Unix time](/en-US/docs/Glossary/Unix_time) in milliseconds, representing the time associated with the notification. This could be in the past when a notification is used for a message that couldn't immediately be delivered because the device was offline, or in the future for a meeting that is about to start. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought "the time at which a notification is actual." was a typo but it is a quote from the spec: https://notifications.spec.whatwg.org/#timestamp. Maybe we should keep it? I don't love "associated with" either.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW I am OK with this and would have complained about "actual".
These are not real interfaces but a kind of WebIDL-only typedef. We wanted to remove them for a long time.
This PR adapts all occurrences of
DOMTimestamp
andEpochTimestamp
.This is part of the cleaning needed for having the whole of Web/API covered with
page-type:
YAML headers. (See #16255)