-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Web/API page types, part 1 #16667
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
If you are using tags to identify the page types then there are some mis-tagged pages. e.g. registerPaint (#16672 will fix this page). We need to update the structure documents to include these.
|
Yes, I know there are errors in tags. I'm not using tags. No doubt I have made some mistakes of my own though!
Yes -> #15539
Yes. I think eventually, with various projects, we might well make all current tags redundant. |
@@ -1,6 +1,7 @@ | |||
--- | |||
title: AddressErrors | |||
slug: Web/API/AddressErrors | |||
page-type: web-api-interface |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically, AddressErrors
is not an interface but a dictionary. We want to get rid of dictionaries because their names are not visible to web devs. They are only objects.
I have no problem tagging them as interfaces for the moment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I tagged these as interfaces after the discussion in #15539 (comment).
@@ -1,6 +1,7 @@ | |||
--- | |||
title: AesCbcParams | |||
slug: Web/API/AesCbcParams | |||
page-type: web-api-interface |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a dictionary (of a kind we want to keep, though)
@@ -1,6 +1,7 @@ | |||
--- | |||
title: AesCtrParams | |||
slug: Web/API/AesCtrParams | |||
page-type: web-api-interface |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a dictionary (of a kind we want to keep, though)
@@ -1,6 +1,7 @@ | |||
--- | |||
title: AesGcmParams | |||
slug: Web/API/AesGcmParams | |||
page-type: web-api-interface |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a dictionary (of a kind we want to keep, though)
@@ -1,6 +1,7 @@ | |||
--- | |||
title: AesKeyGenParams | |||
slug: Web/API/AesKeyGenParams | |||
page-type: web-api-interface |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a dictionary (of a kind we want to keep, though)
I'm approving, but not merging, to give everybody an opportunity to give feedback. We have not discussed this, but you have considered dictionaries as interfaces. Generally, we want to get rid of dictionaries (like I have no problem in tagging them as interfaces for the moment.
I would prefer to separate the different activities in different PRs: adding I think we should do this in 5 phases:
Points 1. to 3. are pretty clear, 4. to 5. still need some work. I prefer smaller contained steps than doing them all at the same time: less risky. |
This looks good to me - I think the page types are intuitive. Some other thoughts (which are out of scope for this pr but I'll put them here anyway):
|
Thank you Ruth! I agree that I'll keep #15539 (comment) updated with a complete list of the page-type values, as we go. |
We could also:
...because sidebars should use short-title (and once sidebars are updated in (3), they won't care about I think
|
This is part 1 of a series of PRs to add page types to the Web/API documentation.
This one is experimental, to see what it would look like. But if we like this I will file more like this, with 200 pages in each PR (about 30 PRs total to get through the set).
I've used the same page type names as in #16255, except lowercased and with dashes for spaces.
I'm going to ignore any pages that were identified as problematic in #16255.
It would be easy to do title updates and add short-title at the same time, maybe we should? But we would need a clear definition of all the titles and also updates to the sidebars (if we have short-title then these would be pretty simple though I think).
@Rumyra , @teoli2003 , @fiji-flo wdyt?