Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

image-resolution: no browser supports it #16026

Merged
merged 1 commit into from
May 15, 2022
Merged

Conversation

teoli2003
Copy link
Contributor

The two spec/browser compat tables were broken: as nobody implements this feature, it has no bcd entry.

This PR:

  • use spec-url in Yaml to link to the spec
  • remove the {{Compat}} and replace it with a text instead of the broken table message.

@teoli2003 teoli2003 requested a review from a team as a code owner May 14, 2022 06:26
@teoli2003 teoli2003 requested review from estelle and removed request for a team May 14, 2022 06:26
@github-actions github-actions bot added the Content:CSS Cascading Style Sheets docs label May 14, 2022
@github-actions
Copy link
Contributor

Preview URLs

Flaws

URL: /en-US/docs/Web/CSS/image-resolution
Title: image-resolution
on GitHub
Flaw count: 1

  • macros:
    • `/home/runner/work/content/content/node_modules/@mdn/yari/kumascript/macros/Specifications.ejs:1

1| <%
2| /*
3| Placeholder to render a specification section with spec_urls from BCD
4|

No first query argument or 'browser-compat' or 'spec-urls' front-matter value passed`

External URLs

URL: /en-US/docs/Web/CSS/image-resolution
Title: image-resolution
on GitHub

No new external URLs

@sideshowbarker sideshowbarker merged commit 9707a88 into main May 15, 2022
@sideshowbarker sideshowbarker deleted the teoli2003-patch-3 branch May 15, 2022 09:50
@wbamberg
Copy link
Collaborator

@hamishwillee , @queengooborg , the same applies to this as to #16066, only in this case it's not even supported behind a pref.

Again I would prefer it if we had BCD for CSS properties like this:

  • it gives a clear answer to BCD consumers (they can know whether it's actually not supported, or just hasn't been documented yet)
  • it means we could have a clearer and simpler structure for CSS properties

@teoli2003
Copy link
Contributor Author

I would be all for having something in bcd, or if not possible in YAML, that indicates that there is no support.

Also, we should be stricter in not accepting docs about features that are not yet implemented: they can stay forever (like this property) not implemented, they can change and this leads to false expectations for web developers.

@wbamberg
Copy link
Collaborator

Yeah I agree: we can decide not to have pages from some features that we think are a long way off implementation, but if we have pages, we should have BCD.

@hamishwillee
Copy link
Collaborator

but if we have pages, we should have BCD.

BCD normally takes the view that things need to at least have some kind of implementation. The reason being that quite a lot of things make it to spec and never go further.

Personally I'd like to have this in BCD but perhaps with infrastructure to make it more clear that a doc is a placeholder and everything below is not supported. E.g. "support": false rather than a tree for these cases.

@teoli2003
Copy link
Contributor Author

Can we do something like:
if no browser-compat: YAML key, or if it leads to nothing, the {{Compat}} will display a standard message informing about no support?

(Note that if we use bcd as the source of trust for information about experimental/deprecated/non-standard, the problem will only thicken as we will need to deal with these cases too)

@queengooborg
Copy link
Collaborator

Before defaulting to saying that a feature isn't supported in any browser, I'd first like to come to a decision on the corresponding guideline, see mdn/browser-compat-data#10619 for details. While we have been removing features that are all false and not merging any new data, I'd still like to come to a concrete decision before we represent it in Yari.

As for the statuses, perhaps we can use a meta tag like "status" that acts as an intermediary if BCD data doesn't exist, similar to how spec_url works?

@mdn mdn deleted a comment from KRYST555 May 17, 2022
hamishwillee pushed a commit to hamishwillee/content that referenced this pull request May 23, 2022
@mdn mdn deleted a comment from KRYST555 Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:CSS Cascading Style Sheets docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants