Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt api.Document.onvisibilitychange to new events structure #13206

Merged
merged 2 commits into from
Mar 7, 2022
Merged

Adapt api.Document.onvisibilitychange to new events structure #13206

merged 2 commits into from
Mar 7, 2022

Conversation

queengooborg
Copy link
Collaborator

@queengooborg queengooborg commented Feb 22, 2022 •
edited
Loading

This PR adapts the visibilitychange event of the Document API to conform to the new events structure.

BCD PR: mdn/browser-compat-data#15084

@queengooborg
Adapt api.Document.onvisibilitychange to new events structure
e25d7a2 
This PR adapts the visibilitychange event of the Document API to conform to the new events structure.
@queengooborg queengooborg requested review from a team as code owners February 22, 2022 11:55
@queengooborg queengooborg requested review from jpmedley and ddbeck and removed request for a team February 22, 2022 11:55
@github-actions github-actions bot added the Content:WebAPI Web API docs label Feb 22, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Feb 22, 2022 •
edited
Loading

Preview URLs

Flaws

Note! 2 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/Document
Title: Document
on GitHub
Flaw count: 35

  • macros:
    • wrong xref macro used (consider changing which macro you use)
    • /en-US/docs/Web/API/HTMLAllCollection does not exist
    • /en-US/docs/Web/API/Document/xmlStandalone does not exist
    • /en-US/docs/Web/API/Document/captureEvents does not exist
    • /en-US/docs/Web/API/Document/createAttributeNS does not exist
    • and 13 more flaws omitted
  • broken_links:
    • Can't resolve /en-US/docs/Web/API/Document_Object_Model/Using_the_W3C_DOM_Level_1_Core
    • Can't resolve /en-US/docs/XUL_Overlays
  • bad_bcd_links:
    • no explanation!
    • no explanation!
    • no explanation!
    • no explanation!
    • no explanation!
    • and 10 more flaws omitted

External URLs

URL: /en-US/docs/Web/API/Document
Title: Document
on GitHub

URL: /en-US/docs/Web/API/Document/visibilitychange_event
Title: Document: visibilitychange event
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Page_Visibility_API
Title: Page Visibility API
on GitHub

No new external URLs

(this comment was updated 2022-03-05 14:31:07.017373)

jpmedley
jpmedley requested changes Feb 22, 2022
View reviewed changes
files/en-us/web/api/document/index.md
@@ -130,8 +130,6 @@ _The `Document` interface is extended with additional event handlers defined in
- : Represents the event handling code for the {{domxref("Document/readystatechange_event", "readystatechange")}} event.
- {{DOMxRef("GlobalEventHandlers.onselectionchange")}} {{Experimental_Inline}}
- : Is an [event handler](/en-US/docs/Web/Events/Event_handlers) representing the code to be called when the {{domxref("Document/selectionchange_event", "selectionchange")}} event is raised.
- {{DOMxRef("Document.onvisibilitychange")}}
- : Is an [event handler](/en-US/docs/Web/Events/Event_handlers) representing the code to be called when the {{domxref("Document/visibilitychange_event", "visibilitychange")}} event is raised.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand that doing this the new way would require you to update all of the event pages together. I'm wondering if we should accept a mix of old and new on some interfaces for the same of keeping the reference complete.

@ddbeck, what do you thin?

files/en-us/web/api/page_visibility_api/index.md Show resolved Hide resolved
@jpmedley jpmedley merged commit 8331519 into mdn:main Mar 7, 2022
@queengooborg queengooborg deleted the api/Document/visibilitychange branch March 7, 2022 16:10
wbamberg added a commit to wbamberg/content that referenced this pull request Mar 8, 2022
@wbamberg
Merge remote-tracking branch 'upstream/main' into js-la-update-webapi-3
c84fc72 
* upstream/main: (237 commits)
  Fixes anchor to browser compatibility table (mdn#13549)
  Fix incorrect casing of getTitlebarAreaRect (mdn#13631)
  Typo (missing s for plural) (mdn#13609)
  Fix a link (mdn#13621)
  Reduce redirects (mdn#13618)
  Adapt api.Window.onappinstalled to new events structure (mdn#13615)
  Add an example on how to list files from a `FileSystemDirectoryHandle` (mdn#13510)
  Fix a llink in the async Learn module (mdn#13623)
  Undo incorrect fix to justify-items syntax (mdn#13622)
  JS Learn: update client-side APIs, part 2 (mdn#13123)
  JS Learn area: async module rewrite (mdn#12930)
  Fix a link (mdn#13619)
  JS Learn: update client-side APIs, part 1 (mdn#13121)
  Adapt api.SharedWorker.onerror to new events structure (mdn#13599)
  Adapt api.OfflineAudioContext.oncomplete to new events structure (mdn#13568)
  Adapt MediaKeySession API to new events structure (mdn#13527)
  Adapt api.Document.onvisibilitychange to new events structure (mdn#13206)
  Change HTML table to a modern list (AudioProcessingEvent) (mdn#13606)
  Adapt api.Performance.onresourcetimingbufferfull to new events structure (mdn#13603)
  Few changes to outline. (mdn#13414)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpmedley jpmedley jpmedley approved these changes

@ddbeck ddbeck Awaiting requested review from ddbeck ddbeck is a code owner automatically assigned from mdn/yari-content-mdn

Assignees
No one assigned
Labels
Content:WebAPI Web API docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@queengooborg @jpmedley