Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt Document fullscreen events to new structure #12926

Merged
merged 1 commit into from
Feb 11, 2022
Merged

Adapt Document fullscreen events to new structure #12926

merged 1 commit into from
Feb 11, 2022

Conversation

queengooborg
Copy link
Collaborator

This PR updates the fullscreenchange and fullscreenerror events of the Document API to conform to the new style.

BCD PR: mdn/browser-compat-data#14939

@queengooborg queengooborg requested review from a team as code owners February 11, 2022 22:39
@queengooborg queengooborg requested review from sideshowbarker and removed request for a team February 11, 2022 22:39
@github-actions github-actions bot added Content:Other Any docs not covered by another "Content:" label Content:WebAPI Web API docs labels Feb 11, 2022
@github-actions
Copy link
Contributor

Preview URLs

Flaws

Note! 3 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Mozilla/Firefox/Releases/49
Title: Firefox 49 for developers
on GitHub
Flaw count: 7

  • macros:
    • /en-US/docs/Web/CSS/align does not exist
    • /en-US/docs/Web/API/ChildNode/before redirects to /en-US/docs/Web/API/Element/before
    • /en-US/docs/Web/API/ChildNode/after redirects to /en-US/docs/Web/API/Element/after
    • /en-US/docs/Web/API/ChildNode/replaceWith redirects to /en-US/docs/Web/API/Element/replaceWith
    • /en-US/docs/Mozilla/Tech/XPCOM/Reference/Interface/EventListenerOptions does not exist
  • broken_links:
    • Can't resolve /en-US/docs/Archive/Firefox_OS/API/Data_Store_API
    • Can't resolve /en-US/docs/Mozilla/Projects/Necko/Proxy_Auto-Configuration_(PAC)_file

URL: /en-US/docs/Web/API/Document
Title: Document
on GitHub
Flaw count: 50

  • macros:
    • wrong xref macro used (consider changing which macro you use)
    • /en-US/docs/Web/API/Document/afterscriptexecute_event does not exist
    • /en-US/docs/Web/API/Document/beforescriptexecute_event does not exist
    • /en-US/docs/Web/API/Document/oncopy does not exist
    • /en-US/docs/Web/API/Document/oncut does not exist
    • and 21 more flaws omitted
  • broken_links:
    • Can't resolve /en-US/docs/Web/API/Document_Object_Model/Using_the_W3C_DOM_Level_1_Core
    • Can't resolve /en-US/docs/XUL_Overlays
  • bad_bcd_links:
    • no explanation!
    • no explanation!
    • no explanation!
    • no explanation!
    • no explanation!
    • and 17 more flaws omitted

URL: /en-US/docs/Web/API/Fullscreen_API
Title: Fullscreen API
on GitHub
Flaw count: 1

  • broken_links:
    • Link points to the page it's already on

External URLs

URL: /en-US/docs/Mozilla/Firefox/Releases/49
Title: Firefox 49 for developers
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/Document
Title: Document
on GitHub


URL: /en-US/docs/Web/API/Document/fullscreenchange_event
Title: Document: fullscreenchange event
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/Document/fullscreenerror_event
Title: Document: fullscreenerror event
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/Fullscreen_API
Title: Fullscreen API
on GitHub


URL: /en-US/docs/Web/API/Fullscreen_API/Guide
Title: Guide to the Fullscreen API
on GitHub

@sideshowbarker sideshowbarker merged commit f75e4cf into mdn:main Feb 11, 2022
@queengooborg queengooborg deleted the api/Document/fullscreen_events branch February 11, 2022 23:21
@Elchi3
Copy link
Member

Elchi3 commented Feb 14, 2022

The template for how to arrange content on _event pages is here: https://developer.mozilla.org/en-US/docs/MDN/Structures/Page_types/API_event_subpage_template. New structure includes a syntax section, "Event type" and "Event properties" (if the Event type isn't a generic Event).

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Content:Other Any docs not covered by another "Content:" label Content:WebAPI Web API docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants