Add Safari versions for CanvasRenderingContext2D API #8666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds real values for Safari (Desktop and iOS/iPadOS) for the `CanvasRenderingContext2D` API, based upon manual testing.
Test Code Used: `var canvas = document.createElement('canvas'); var instance = canvas.getContext('2d'); instance.MEMBER;`
github-actions
bot
added
the
data:api 🐇
foolip
approved these changes
Jan 11, 2021
foolip
added a commit
to foolip/browser-compat-data
that referenced
this pull request
Sep 14, 2022
Support for CanvasPattern is implied by support for ctx.createPattern(), since that's how a CanvasPattern instance is created. Similarly, support for CanvasGradient is implied by support for either createLinearGradient() or createRadialGradient(). The support data for CanvasRenderingContext2D looks reliable based on the PRs that updated it to the current state: mdn#7465 mdn#8666 Update CanvasGradient and CanvasPattern to match. The versions now match for all browsers except Opera, where some ≤12.1 versions were left alone rather than trying to confirm the correct versions.
queengooborg
pushed a commit
that referenced
this pull request
Sep 19, 2022
Support for CanvasPattern is implied by support for ctx.createPattern(), since that's how a CanvasPattern instance is created. Similarly, support for CanvasGradient is implied by support for either createLinearGradient() or createRadialGradient(). The support data for CanvasRenderingContext2D looks reliable based on the PRs that updated it to the current state: #7465 #8666 Update CanvasGradient and CanvasPattern to match. The versions now match for all browsers except Opera, where some ≤12.1 versions were left alone rather than trying to confirm the correct versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds real values for Safari (Desktop and iOS/iPadOS) for the
CanvasRenderingContext2DAPI, based upon manual testing.Test Code Used:
var canvas = document.createElement('canvas'); var instance = canvas.getContext('2d'); instance.MEMBER;