Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing WebGL extensions #7634

Merged
merged 2 commits into from
Dec 17, 2020
Merged

Add missing WebGL extensions #7634

merged 2 commits into from
Dec 17, 2020

Conversation

queengooborg
Copy link
Contributor

This PR is a part of a project to add missing interfaces and interface features to BCD that are from a spec in Editor's Draft or more and is supported in at least one browser. This particular PR adds three missing WebGL extensions, populating the results using data from the mdn-bcd-collector project (v1.1.6).

Specs:
https://www.khronos.org/registry/webgl/extensions/EXT_disjoint_timer_query_webgl2/
https://www.khronos.org/registry/webgl/extensions/EXT_texture_norm16/
https://www.khronos.org/registry/webgl/extensions/WEBGL_multi_draw/

Note: the results for EXT_disjoint_timer_query_webgl2 seem a little bit odd. I've confirmed these results manually however.

This PR is a part of a project to add missing interfaces and interface features to BCD that are from a spec in Editor's Draft or more and is supported in at least one browser.  This particular PR adds three missing WebGL extensions, populating the results using data from the [mdn-bcd-collector](https://mdn-bcd-collector.appspot.com) project (v1.1.6).

Specs:
https://www.khronos.org/registry/webgl/extensions/EXT_disjoint_timer_query_webgl2/
https://www.khronos.org/registry/webgl/extensions/EXT_texture_norm16/
https://www.khronos.org/registry/webgl/extensions/WEBGL_multi_draw/

Note: the results for EXT_disjoint_timer_query_webgl2 seem a little bit odd.  I've confirmed these results manually however.
@github-actions github-actions bot added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Dec 11, 2020
@Elchi3
Copy link
Member

Elchi3 commented Dec 11, 2020

Note: the results for EXT_disjoint_timer_query_webgl2 seem a little bit odd. I've confirmed these results manually however.

I think this one is the webgl 2 extension for https://developer.mozilla.org/en-US/docs/Web/API/EXT_disjoint_timer_query (which is is only for webgl 1). I wonder if both are back now or really just this one, though.

@Elchi3
Copy link
Member

Elchi3 commented Dec 11, 2020

https://www.khronos.org/registry/webgl/extensions/EXT_texture_norm16/

Firefox implements this according to https://bugzilla.mozilla.org/show_bug.cgi?id=1658433. Is it disabled or only available on certain OS / drivers?

@Elchi3
Copy link
Member

Elchi3 commented Dec 14, 2020

Firefox implements this according to https://bugzilla.mozilla.org/show_bug.cgi?id=1658433. Is it disabled or only available on certain OS / drivers?

It is behind a preference: webgl.enable-draft-extensions

@Elchi3
Copy link
Member

Elchi3 commented Dec 16, 2020

I wrote MDN docs for EXT_texture_norm16 and WEBGL_multi_draw, so these should get their mdn_url properties added.

@Elchi3 Elchi3 merged commit b12e0be into mdn:master Dec 17, 2020
@queengooborg queengooborg deleted the api/WebGL branch December 17, 2020 17:01
@haraldreingruber-dedalus
Copy link
Contributor

I just tested via https://webglreport.com/?v=2 on Edge (Version 109), and EXT_texture_norm16 is supported there as well.

I would like to contribute a PR fixing the comp data for this feature. Could you help me figure out what's the best way to do this? @queengooborg @Elchi3?
Do you think I can just copy the version added from Chrome?

@Elchi3
Copy link
Member

Elchi3 commented Jan 31, 2023

@haraldreingruber-dedalus you can use "edge": "mirror" so that it will be in sync with the Chrome version. See https://github.com/mdn/browser-compat-data/blob/main/api/EXT_texture_norm16.json

Please open a new issue or a pull request. Thank you!

@haraldreingruber-dedalus
Copy link
Contributor

Please open a new issue or a pull request. Thank you!

Thanks a lot for the suggestion. I've submitted #18801

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants