Correct Safari data for various Media APIs #7427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
data:api 🐇
foolip
requested changes
Nov 23, 2020
api/MediaStreamAudioSourceNode.json
Outdated
| @@ -29,10 +29,10 @@ | |||
| "version_added": "14" | |||
| }, | |||
| "safari": { | |||
| "version_added": "6" | |||
| "version_added": false | |||
There was a problem hiding this comment.
I suspect this change is incorrect and MediaStreamAudioSourceNode is supported. http://mdn-bcd-collector.appspot.com/tests/api/MediaStreamAudioSourceNode return false in many places making it hard to interpret the results.
@vinyldarkscratch can you check out why we're seeing a false result here?
There was a problem hiding this comment.
@vinyldarkscratch this conversation was resolved but it looks like the change still remains, so reopening.
|
@vinyldarkscratch should any of the changes in api/MediaStreamAudioSourceNode.json remain, or should they be reverted? |
foolip
approved these changes
Nov 24, 2020
foolip
added a commit
that referenced
this pull request
Feb 21, 2022
It was introduced here together with setLiveSeekableRanges: https://trac.webkit.org/changeset/206146/webkit https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/Configurations/Version.xcconfig?rev=206146 Testing https://mdn-bcd-collector.appspot.com/tests/api/MediaSource in Safari 10 and 10.1 in Sauce Labs confirms they were added in 10.1. The data came from #7427 which did come from the collector, but even the results at the time support 10.1 as the correct version: https://raw.githubusercontent.com/foolip/mdn-bcd-results/327933b8a3a402bbb6e880569a2dff104df31698/1.1.3-safari-10.0.1-mac-os-10.11.6-daabd96f93.json https://raw.githubusercontent.com/foolip/mdn-bcd-results/327933b8a3a402bbb6e880569a2dff104df31698/1.1.3-safari-10.1.2-mac-os-10.12.6-142e4c09c5.json Possibly the updater script is buggy or the results were manually edited.
queengooborg
pushed a commit
that referenced
this pull request
Mar 4, 2022
It was introduced here together with setLiveSeekableRanges: https://trac.webkit.org/changeset/206146/webkit https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/Configurations/Version.xcconfig?rev=206146 Testing https://mdn-bcd-collector.appspot.com/tests/api/MediaSource in Safari 10 and 10.1 in Sauce Labs confirms they were added in 10.1. The data came from #7427 which did come from the collector, but even the results at the time support 10.1 as the correct version: https://raw.githubusercontent.com/foolip/mdn-bcd-results/327933b8a3a402bbb6e880569a2dff104df31698/1.1.3-safari-10.0.1-mac-os-10.11.6-daabd96f93.json https://raw.githubusercontent.com/foolip/mdn-bcd-results/327933b8a3a402bbb6e880569a2dff104df31698/1.1.3-safari-10.1.2-mac-os-10.12.6-142e4c09c5.json Possibly the updater script is buggy or the results were manually edited.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR corrects the Safari data for various Media APIs using results from the mdn-bcd-collector project.