Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Opera to ≤12.1 for HTMLFormElement #7107

Merged
merged 1 commit into from
Oct 29, 2020

Conversation

queengooborg
Copy link
Collaborator

This PR uses the mdn-bcd-collector project to set true to ≤12.1 for Opera for the HTMLFormElement API and many of its subfeatures. Data is also mirrored to Opera Android.

@github-actions github-actions bot added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Oct 27, 2020
Copy link
Collaborator

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see two entries not updated in #7056 that I'd like to understand before merging either PR.

@@ -214,10 +214,10 @@
"version_added": null
},
"opera": {
"version_added": true
"version_added": "≤12.1"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the checkValidity entry, not updated by #7056. Is that an oversight, or when was it added to Chrome?

@@ -599,10 +599,10 @@
"version_added": null
},
"opera": {
"version_added": true
"version_added": "≤12.1"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This entry, noValidate, was also not updated in #7056.

@foolip
Copy link
Collaborator

foolip commented Oct 29, 2020

#7105 (comment) and current results in https://github.com/foolip/mdn-bcd-results show that the Opera versions tested are 12.14, 15 and 70. That makes me confident in the results, and I'm not very worried about mismatches what's touched in Chromium and Opera PRs as a result.

I have been and will keep using #6862 to summarize the differences to myself while reviewing, however.

@ddbeck FYI, this explains most of how I've approached these HTML* PRs.

Copy link
Collaborator

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Goes with #7056

@foolip foolip merged commit 48f2def into mdn:master Oct 29, 2020
@ddbeck
Copy link
Collaborator

ddbeck commented Oct 29, 2020

@ddbeck FYI, this explains most of how I've approached these HTML* PRs.

Makes sense. Thank you, @foolip! 👍

@queengooborg queengooborg deleted the api/HTMLFormElement-opera-12-1 branch October 29, 2020 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants