-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set Opera to ≤12.1 for HTMLFormElement #7107
Set Opera to ≤12.1 for HTMLFormElement #7107
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see two entries not updated in #7056 that I'd like to understand before merging either PR.
@@ -214,10 +214,10 @@ | |||
"version_added": null | |||
}, | |||
"opera": { | |||
"version_added": true | |||
"version_added": "≤12.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the checkValidity
entry, not updated by #7056. Is that an oversight, or when was it added to Chrome?
@@ -599,10 +599,10 @@ | |||
"version_added": null | |||
}, | |||
"opera": { | |||
"version_added": true | |||
"version_added": "≤12.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This entry, noValidate
, was also not updated in #7056.
#7105 (comment) and current results in https://github.com/foolip/mdn-bcd-results show that the Opera versions tested are 12.14, 15 and 70. That makes me confident in the results, and I'm not very worried about mismatches what's touched in Chromium and Opera PRs as a result. I have been and will keep using #6862 to summarize the differences to myself while reviewing, however. @ddbeck FYI, this explains most of how I've approached these HTML* PRs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Goes with #7056
This PR uses the mdn-bcd-collector project to set
true
to≤12.1
for Opera for theHTMLFormElement
API and many of its subfeatures. Data is also mirrored to Opera Android.