Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove never-supported Budget APIs #6924

Merged
merged 1 commit into from
Oct 22, 2020
Merged

Conversation

saschanaz
Copy link
Contributor

A checklist to help your pull request get merged faster:

  • Summarize your changes
  • Data: link to resources that verify support information (such as browser's docs, changelogs, source control, bug trackers, and tests)
  • Data: if you tested something, describe how you tested with details like browser and version
  • Review the results of the linter and fix problems reported (If you need help, please ask in a comment!)
  • Link to related issues or pull requests, if any: Remove items that has never been supported #6854, Remove totally unimplemented things #6768

@github-actions github-actions bot added data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API linter 🏡 Issues or pull requests regarding the tests / linter of the JSON files. labels Oct 15, 2020
@queengooborg queengooborg removed the request for review from ddbeck October 16, 2020 08:15
@queengooborg queengooborg removed the linter 🏡 Issues or pull requests regarding the tests / linter of the JSON files. label Oct 16, 2020
Copy link
Collaborator

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm this with the commit message I wrote for #6535:

Only the reserve() method was shipped, and later removed:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/yBtmc-4xl_o/GE0vneAVDQAJ
https://groups.google.com/a/chromium.org/d/msg/blink-dev/18r3whCBv0I/b8qrtFTsDAAJ

https://software.hixie.ch/utilities/js/live-dom-viewer/?saved=8362 was
tested on Chrome and Opera on Windows to verify the ranges. Android
WebView was never supported per the blink-dev intent, and the other data
was mirrored.

@foolip foolip merged commit f598ad5 into mdn:master Oct 22, 2020
@ddbeck
Copy link
Collaborator

ddbeck commented Oct 29, 2020

@chrisdavidmills We did this removal before we discussed how to handle the disposition of pages. Would you mind deleting the https://wiki.developer.mozilla.org/docs/Web/API/BudgetState tree?

@ddbeck
Copy link
Collaborator

ddbeck commented Oct 29, 2020

@chrisdavidmills actually, on second thought, there a couple of others to consider. I'll open an issue on mdn/sprints with a list of all of them instead. Sorry for the noise.

@chrisdavidmills
Copy link
Collaborator

It's all good. I just deleted the BudgetState tree.

@ddbeck
Copy link
Collaborator

ddbeck commented Oct 29, 2020

@chrisdavidmills Oh, good news: that was all of them after all. Thank you!

@saschanaz saschanaz deleted the nosupport-budget branch December 29, 2020 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants