Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linter for support blocks filled only with false #6809

Closed
wants to merge 23 commits into from

Conversation

saschanaz
Copy link
Contributor

@saschanaz saschanaz commented Oct 3, 2020

A checklist to help your pull request get merged faster:

This implements a linter to prevent any support block filled only with false.

Quite a lot of failures, not sure how to proceed. Maybe create an allowlist for now and try reducing it later?

@saschanaz saschanaz requested a review from ddbeck as a code owner October 3, 2020 19:32
@github-actions github-actions bot added the linter 🏡 Issues or pull requests regarding the tests / linter of the JSON files. label Oct 3, 2020
@saschanaz

This comment has been minimized.

@saschanaz saschanaz changed the title Lint support blocks filled only with false Add linter for support blocks filled only with false Oct 3, 2020
@queengooborg queengooborg added the not ready ⛔ This is not yet ready to be merged. It's pending a decision, other PR, or a prerequisite action. label Oct 5, 2020
@queengooborg
Copy link
Collaborator

Marking as "not ready" since we need to fix our data first.

@foolip
Copy link
Collaborator

foolip commented Jun 9, 2021

Could this be tweaked to test for falsy values to include null? That's the lint I think we should have :)

@saschanaz
Copy link
Contributor Author

We had way too many false-only items so I intended to make the scope smaller here. But since we removed quite a lot of them, maybe it's now time to cover null.

@foolip
Copy link
Collaborator

foolip commented Jun 9, 2021

That's a kind of progress! Would you mind updating what would still be failing this lint now? (I could, but am on phone but still curious...)

@saschanaz
Copy link
Contributor Author

saschanaz commented Jun 9, 2021

Already did 😉 (I mean, #6854)

@saschanaz
Copy link
Contributor Author

Problems in 116 files:
✖ api/BluetoothRemoteGATTService.json
✖ api/ConstrainULong.json
✖ api/MediaTrackSettings.json
✖ api/MediaTrackSupportedConstraints.json
✖ api/MouseEvent.json
✖ api/PaymentResponse.json
✖ api/PushRegistrationManager.json
✖ api/PushSubscriptionChangeEvent.json
✖ api/RTCDataChannel.json
✖ api/RTCIceCandidatePairStats.json
✖ api/RTCIceCandidateStats.json
✖ api/RTCIceCandidateType.json
✖ api/RTCIceComponent.json
✖ api/RTCIceCredentialType.json
✖ api/RTCIdentityAssertion.json
✖ api/RTCIdentityProviderGlobalScope.json
✖ api/RTCIdentityProviderRegistrar.json
✖ api/RTCRtpEncodingParameters.json
✖ api/RTCRtpSendParameters.json
✖ api/RTCRtpStreamStats.json
✖ api/Request.json
✖ api/SVGElement.json
✖ api/SVGImageElement.json
✖ api/SourceBuffer.json
✖ api/TouchList.json
✖ api/ULongRange.json
✖ api/VRDisplay.json
✖ api/VREyeParameters.json
✖ api/VRFieldOfView.json
✖ api/VRPose.json
✖ api/Window.json
✖ api/XRPermissionDescriptor.json
✖ api/XRPermissionStatus.json
✖ css/properties/font-variant.json
✖ css/properties/masonry-auto-flow.json
✖ css/properties/text-align.json
✖ css/properties/text-indent.json
✖ css/properties/text-overflow.json
✖ css/selectors/target-within.json
✖ css/types/frequency.json
✖ css/types/length-percentage.json
✖ css/types/length.json
✖ html/elements/menu.json
✖ html/elements/textarea.json
✖ html/manifest/dir.json
✖ html/manifest/iarc_rating_id.json
✖ html/manifest/lang.json
✖ http/headers/content-security-policy.json
✖ http/headers/cookie2.json
✖ http/headers/expect.json
✖ http/headers/feature-policy.json
✖ http/headers/forwarded.json
✖ http/headers/set-cookie2.json
✖ http/headers/tk.json
✖ http/headers/x-forwarded-for.json
✖ http/headers/x-forwarded-host.json
✖ http/headers/x-forwarded-proto.json
✖ http/methods.json
✖ svg/attributes/conditional_processing.json
✖ svg/attributes/core.json
✖ svg/attributes/events.json
✖ svg/attributes/presentation.json
✖ svg/attributes/xlink.json
✖ svg/elements/a.json
✖ svg/elements/altGlyph.json
✖ svg/elements/altGlyphDef.json
✖ svg/elements/altGlyphItem.json
✖ svg/elements/animate.json
✖ svg/elements/animateColor.json
✖ svg/elements/animateMotion.json
✖ svg/elements/animateTransform.json
✖ svg/elements/cursor.json
✖ svg/elements/feConvolveMatrix.json
✖ svg/elements/feDiffuseLighting.json
✖ svg/elements/feDisplacementMap.json
✖ svg/elements/feDistantLight.json
✖ svg/elements/feFlood.json
✖ svg/elements/feGaussianBlur.json
✖ svg/elements/feImage.json
✖ svg/elements/feSpecularLighting.json
✖ svg/elements/feTurbulence.json
✖ svg/elements/filter.json
✖ svg/elements/font-face-format.json
✖ svg/elements/font-face-name.json
✖ svg/elements/font-face-src.json
✖ svg/elements/font-face-uri.json
✖ svg/elements/font-face.json
✖ svg/elements/font.json
✖ svg/elements/glyph.json
✖ svg/elements/glyphRef.json
✖ svg/elements/hatch.json
✖ svg/elements/hatchpath.json
✖ svg/elements/hkern.json
✖ svg/elements/image.json
✖ svg/elements/linearGradient.json
✖ svg/elements/mask.json
✖ svg/elements/mesh.json
✖ svg/elements/meshgradient.json
✖ svg/elements/meshpatch.json
✖ svg/elements/meshrow.json
✖ svg/elements/missing-glyph.json
✖ svg/elements/mpath.json
✖ svg/elements/radialGradient.json
✖ svg/elements/script.json
✖ svg/elements/style.json
✖ svg/elements/svg.json
✖ svg/elements/symbol.json
✖ svg/elements/textPath.json
✖ svg/elements/tref.json
✖ svg/elements/tspan.json
✖ svg/elements/view.json
✖ svg/elements/vkern.json
✖ javascript/builtins/Array.json
✖ javascript/builtins/String.json
✖ javascript/builtins/TypedArray.json
✖ xslt/elements/stylesheet.json

Latest update.

@foolip
Copy link
Collaborator

foolip commented Jun 9, 2021

Nice, a lot more bad data to sort through :)

@github-actions
Copy link

github-actions bot commented Jun 1, 2022

This pull request has merge conflicts that must be resolved before it can be merged.

@queengooborg
Copy link
Collaborator

Hey @saschanaz, would you be down to update this? We've decided to proceed with disallowing all-false features in BCD!

@github-actions
Copy link

This pull request has merge conflicts that must be resolved before it can be merged.

@saschanaz
Copy link
Contributor Author

saschanaz commented Nov 24, 2022

Found #16429 merged first with kinda similar purpose. Not sure what should I do, should I merge this with that one? This one seems to cover more things, at least. @queengooborg

@saschanaz
Copy link
Contributor Author

Okay, found #17743. Can you please ping me before such decision.

@saschanaz saschanaz deleted the lint-nosupport branch February 26, 2023 08:20
@saschanaz
Copy link
Contributor Author

Not sure how should I feel with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
linter 🏡 Issues or pull requests regarding the tests / linter of the JSON files. not ready ⛔ This is not yet ready to be merged. It's pending a decision, other PR, or a prerequisite action. scripts 📜 Issues or pull requests regarding the scripts in scripts/.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants