Update support data for Animation and KeyframeEffect #6528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
data:api
|
Note that only Chrome on Windows has been tested. The fact that the controlling flags are dropped in https://chromium-review.googlesource.com/c/chromium/src/+/1564568 is used to assume that this is in all browsers based on Chromium M75 or later, since extra work would be needed to disable it. |
foolip
commented
Aug 18, 2020
|
@vinyldarkscratch can you review this? |
queengooborg
requested changes
Aug 19, 2020
There was a problem hiding this comment.
Looks all good to me, thanks! Regarding the Edge version, I think it makes sense to set the version to just 79 since we have already verified it wasn't present in the previous version (18)? (This applies to KeyframeEffect as well, if we want to update those versions here?)
The AnimationEffect data is already good, but Animation's effect attribute and KeyframeEffect with constructor and target attribute weren't updated. These changes landed together in Chromium M75: https://chromium-review.googlesource.com/c/chromium/src/+/1564568 The Animation and KeyframeEffect interfaces were verified to not exist in Edge 18, so the Edge version was set/updated to "75". These data points support this as well: https://caniuse.com/#feat=web-animation https://developer.microsoft.com/en-us/microsoft-edge/status/webanimationsjavascriptapi/
foolip
force-pushed
the
chrome-75-animation
branch
from
bcd1a30 to
ec93b69
Compare
foolip
changed the title
|
Thanks @vinyldarkscratch! I've made those changes and updated the description. |
jpmedley
suggested changes
Aug 20, 2020
queengooborg
approved these changes
Aug 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AnimationEffect data is already good, but Animation's effect
attribute and KeyframeEffect with constructor and target attribute
weren't updated.
These changes landed together in Chromium M75:
https://chromium-review.googlesource.com/c/chromium/src/+/1564568
The Animation and KeyframeEffect interfaces were verified to not exist
in Edge 18, so the Edge version was set/updated to "75". These data
points support this as well:
https://caniuse.com/#feat=web-animation
https://developer.microsoft.com/en-us/microsoft-edge/status/webanimationsjavascriptapi/