Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Safari to browser data and fix invalid versions #595

Merged
merged 2 commits into from
Nov 5, 2017
Merged

Conversation

Elchi3
Copy link
Member

@Elchi3 Elchi3 commented Nov 3, 2017

No description provided.

@Elchi3 Elchi3 added the linter 🏡 Issues or pull requests regarding the tests / linter of the JSON files. label Nov 3, 2017
@Elchi3 Elchi3 added data:browsers 🌍 Data about browsers (versions, release dates, etc). This data is used for validation. and removed linter 🏡 Issues or pull requests regarding the tests / linter of the JSON files. labels Nov 3, 2017
@teoli2003 teoli2003 changed the title Add Safari to browser data and fix invalid verisons Add Safari to browser data and fix invalid versions Nov 5, 2017
Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, r+; safari_ios may be more tricky though.

@teoli2003 teoli2003 merged commit a23c50b into master Nov 5, 2017
@Elchi3 Elchi3 deleted the safari branch November 6, 2017 11:52
foolip added a commit to foolip/browser-compat-data that referenced this pull request Jun 18, 2021
The 2013-06-11 date was originally added here:
mdn#595

Source for 2013-10-22:
https://en.wikipedia.org/wiki/Safari_version_history#Safari_6

This also makes more sense in light of the relationship between Safari 6
and 7.1, see mdn#9423 (comment).
Elchi3 pushed a commit that referenced this pull request Jun 18, 2021
The 2013-06-11 date was originally added here:
#595

Source for 2013-10-22:
https://en.wikipedia.org/wiki/Safari_version_history#Safari_6

This also makes more sense in light of the relationship between Safari 6
and 7.1, see #9423 (comment).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:browsers 🌍 Data about browsers (versions, release dates, etc). This data is used for validation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants