-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: executable script consistency #5890
Merged
queengooborg
merged 23 commits into
mdn:main
from
queengooborg:refactor/shbang-and-use-strict
May 17, 2022
Merged
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
f2af1c2
Refactor: only include env on executable scripts and use strict on all
queengooborg 6dc2381
Make all executables importable
queengooborg 948076f
Merge branch 'master' into refactor/shbang-and-use-strict
queengooborg 233c09b
Merge branch 'master' into refactor/shbang-and-use-strict
queengooborg bf57e3a
Merge branch 'master' into refactor/shbang-and-use-strict
queengooborg 843e200
Merge branch 'master' into refactor/shbang-and-use-strict
queengooborg 4702ac0
Merge branch 'main' into refactor/shbang-and-use-strict
queengooborg c1dffd0
Update new scripts
queengooborg ef5684a
Merge branch 'main' into refactor/shbang-and-use-strict
queengooborg 56856e0
Merge branch 'main' into refactor/shbang-and-use-strict
queengooborg e81017a
Merge branch 'main' into refactor/shbang-and-use-strict
queengooborg 17eabb5
Merge branch 'main' into refactor/shbang-and-use-strict
queengooborg 387c6fe
Update all script files
queengooborg 8612d0c
Merge branch 'main' into refactor/shbang-and-use-strict
queengooborg 76de15c
Fix files within index
queengooborg 8ae9314
Merge branch 'main' into refactor/shbang-and-use-strict
queengooborg 7f4da8a
Merge branch 'main' into refactor/shbang-and-use-strict
queengooborg e098f68
Fix formatting
queengooborg e687059
Merge branch 'main' into refactor/shbang-and-use-strict
queengooborg 4178c4f
Merge branch 'main' into refactor/shbang-and-use-strict
queengooborg 29289f9
Merge branch 'main' into refactor/shbang-and-use-strict
queengooborg 83ff421
Undo unrelated changes
queengooborg 86330a3
Remove obsolete function call
queengooborg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -73,4 +73,6 @@ function main() { | |
} | ||
} | ||
|
||
main(); | ||
if (require.main === module) { | ||
main(); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -143,4 +143,6 @@ async function main() { | |
); | ||
} | ||
|
||
main(); | ||
if (require.main === module) { | ||
main(); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does this script not have an
if (require.main === module) {
block?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This script isn't supposed to be run on its own, but rather as a Mocha unittest. It was never actually hooked up though, and I'm not too worried about hooking it up now since it's going to be removed in #15781!