Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebExtensions - Add chrome theme color properties #581

Merged
merged 4 commits into from
Oct 31, 2017
Merged

WebExtensions - Add chrome theme color properties #581

merged 4 commits into from
Oct 31, 2017

Conversation

nt1m
Copy link
Contributor

@nt1m nt1m commented Oct 30, 2017

Google chrome supports more properties

@Elchi3 Elchi3 added the data:webext Compat data for Browser Extensions. https://developer.mozilla.org/Add-ons/WebExtensions label Oct 30, 2017
@wbamberg
Copy link
Contributor

This looks great, but please alphabetize the properties, so it's easier to read.

@wbamberg wbamberg self-requested a review October 31, 2017 17:14
wbamberg
wbamberg requested changes Oct 31, 2017
View reviewed changes
Copy link
Contributor

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please order the properties alphabetically. Otherwise, this looks great!

@nt1m
Copy link
Contributor Author

nt1m commented Oct 31, 2017 •
edited
Loading

@wbamberg Done

@wbamberg
Copy link
Contributor

I think the ntp_* ones are still not ordered?

@nt1m
Copy link
Contributor Author

nt1m commented Oct 31, 2017

@wbamberg Updated

wbamberg
wbamberg approved these changes Oct 31, 2017
View reviewed changes
Copy link
Contributor

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nt1m !

@wbamberg wbamberg merged commit 1d0e354 into mdn:master Oct 31, 2017
queengooborg added a commit to queengooborg/browser-compat-data that referenced this pull request Aug 10, 2024
@queengooborg
Update Chromium data for webextensions.manifest.theme.colors
2fdcd04 
This PR updates and corrects version values for Chromium (Chrome, Opera, Samsung Internet, WebView Android) for the `colors` member of the `theme` Web Extensions manifest property. This sets the feature(s) to a version range based upon the date that the feature was added to BCD with the intent of replacing `true` values with ranged values to eliminate `true` values from BCD.

Commit/PR Adding the Feature: mdn#581, mdn#1721
@queengooborg queengooborg mentioned this pull request Aug 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wbamberg wbamberg wbamberg approved these changes

Assignees
No one assigned
Labels
data:webext Compat data for Browser Extensions. https://developer.mozilla.org/Add-ons/WebExtensions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nt1m @wbamberg @Elchi3