Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Intl ctors; remove Intl prototypes #5709

Merged
merged 2 commits into from
Feb 20, 2020
Merged

Add Intl ctors; remove Intl prototypes #5709

merged 2 commits into from
Feb 20, 2020

Conversation

Elchi3
Copy link
Member

@Elchi3 Elchi3 commented Feb 14, 2020

Background mdn/sprints#2571

PluralRules and RelativeTimeFormat already have constructor data, so there I just removed the prototype entry.

@Elchi3 Elchi3 requested a review from wbamberg February 14, 2020 15:49
@ghost ghost added the data:js Compat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript label Feb 14, 2020
@bershanskiy bershanskiy mentioned this pull request Feb 14, 2020
Copy link
Contributor

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine except for what looks like one copy/paste error for DateTimeFormat's "description".

The URLs here are like:
"/JavaScript/Reference/Global_Objects/Collator/Collator". From mdn/sprints#2537 (comment) I had thought we would nest these objects in their namespace, which would give us URLs like "/JavaScript/Reference/Global_Objects/Intl/Collator/Collator". Or is that for a next step?

javascript/builtins/intl/DateTimeFormat.json Outdated Show resolved Hide resolved
@Elchi3
Copy link
Member Author

Elchi3 commented Feb 19, 2020

This looks fine except for what looks like one copy/paste error for DateTimeFormat's "description".

Great catch, thank you! I've fixed this.

The URLs here are like:
"/JavaScript/Reference/Global_Objects/Collator/Collator". From mdn/sprints#2537 (comment) I had thought we would nest these objects in their namespace, which would give us URLs like "/JavaScript/Reference/Global_Objects/Intl/Collator/Collator". Or is that for a next step?

I would say lets do this in a next step. The constructor work took already longer than I thought, so the Intl moves should be looked at separately. I will do that this sprint if the other scheduled work items will be done early, but otherwise I plan to get to it next sprint.

Copy link
Contributor

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update, @Elchi3 . Looks good to me!

@wbamberg wbamberg merged commit b8e007c into master Feb 20, 2020
@Elchi3 Elchi3 deleted the intl-ctors branch February 20, 2020 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:js Compat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants