-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add compat for BigInt #3224
Add compat for BigInt #3224
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your help on this.
Fixed some errors: #3224.
I added a commit to fix the errors. |
Added Node.js compat data
I added a commit with the Node.js compatibility, and put it in the correct folder |
I un-localized the URL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple style fixes and this will be ready to merge. Thank you for your help on this, @VFDan!
Fixed some style errors
I added a commit with those style changes. |
Travis CI says: "
" |
It appears that your line endings aren't just new lines (i.e., your line endings are Windows rather than Unix style). I've opened PR #3231 to highlight this better. In the mean time, there's probably an option in your editor to convert line endings, which should fix the problem. |
I changed the line endings (I said Unicode but meant Unix). Travis CI said the same thing. Maybe there is a bug with Travis CI, because I changed the line endings |
Thank you for merging the commits! I'm also on MDN under the username VFDan. |
I put the compatibility table in the MDN BigInt page. |
The BigInt compatibility table is needed:
Sorry, the file should be in the javascript/builtins/ folder.