Add initial pull request template #3208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddbeck
added
infra 🏗️
Elchi3
reviewed
Dec 13, 2018
.github/PULL_REQUEST_TEMPLATE
Outdated
| @@ -0,0 +1,6 @@ | |||
| A checklist to help your pull request get merged faster: | |||
| - [ ] Summarize your changes | |||
| - [ ] Data: link to supporting info (examples: docs, changelogs, source control, bug trackers, tests) | |||
There was a problem hiding this comment.
Not sure if it is crystal clear what we mean with "supporting info" here. Maybe:
- [ ] Provide resources that help verifying support information (links to the browser's docs, changelogs, source control, bug trackers, tests)
There was a problem hiding this comment.
Good idea. Pushed another version of this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims adds a little pull request template to help catch a few things that increase friction on PR reviews (e.g., no description, no background info, linter problems, etc.).