Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chrome 121 supports display-p3 color space for GPUDevice.importExternalTexture() #25156

Merged

Conversation

chrisdavidmills
Copy link
Contributor

Summary

Chrome 121 supports the display-p3 color space for GPUDevice.importExternalTexture() - see https://developer.chrome.com/blog/new-in-webgpu-121#support_display-p3_as_gpuexternaltexture_color_space

This PR adds a data point for it.

Test results and supporting details

Related issues

Project issue: mdn/content#36353.

@github-actions github-actions bot added data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API size:m [PR only] 25-100 LoC changed labels Nov 20, 2024
Copy link
Contributor

@beaufortfrancois beaufortfrancois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nit

"notes": "Currently supported on ChromeOS, macOS, and Windows only."
},
"chrome_android": {
"version_added": "121"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: You can mirror since it's the same version.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only reason I didn't mirror is that I thought it would also mirror the note, and "Currently supported on ChromeOS, macOS, and Windows only." is not relevant to Chrome Android?

I'm pretty sure I am correct here, as the BCD linter didn't tell me to mirror it when I ran the tests.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha!

Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Compact diff by value (ignoring mirroring):
image

@caugner caugner changed the title Add data point for display-p3 color space Chrome 121 supports display-p3 color space for GPUDevice.importExternalTexture() Nov 21, 2024
@caugner caugner merged commit 89212bc into mdn:main Nov 21, 2024
6 checks passed
@mdn-bot mdn-bot mentioned this pull request Nov 21, 2024
@chrisdavidmills chrisdavidmills deleted the display-p3-color-space-importexternaltexture branch November 22, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API size:m [PR only] 25-100 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants