-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chrome 121 supports display-p3 color space for GPUDevice.importExternalTexture() #25156
Chrome 121 supports display-p3 color space for GPUDevice.importExternalTexture() #25156
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with nit
"notes": "Currently supported on ChromeOS, macOS, and Windows only." | ||
}, | ||
"chrome_android": { | ||
"version_added": "121" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: You can mirror since it's the same version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only reason I didn't mirror is that I thought it would also mirror the note, and "Currently supported on ChromeOS, macOS, and Windows only." is not relevant to Chrome Android?
I'm pretty sure I am correct here, as the BCD linter didn't tell me to mirror it when I ran the tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotcha!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary
Chrome 121 supports the
display-p3
color space forGPUDevice.importExternalTexture()
- see https://developer.chrome.com/blog/new-in-webgpu-121#support_display-p3_as_gpuexternaltexture_color_spaceThis PR adds a data point for it.
Test results and supporting details
Related issues
Project issue: mdn/content#36353.