-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove api.PageRevealEvent.PageRevealEvent from BCD #23707
Remove api.PageRevealEvent.PageRevealEvent from BCD #23707
Conversation
This PR removes the `PageRevealEvent` member of the `PageRevealEvent` API from BCD. Per the [data guidelines](https://github.com/mdn/browser-compat-data/blob/main/docs/data-guidelines/index.md#removal-of-irrelevant-features), this feature can be considered irrelevant and may be removed from BCD accordingly. Even if the current data suggests that the feature is supported, lack of support has been confirmed by the [mdn-bcd-collector](https://mdn-bcd-collector.gooborg.com) project (v10.11.0). Tests Used: https://mdn-bcd-collector.gooborg.com/tests/api/PageRevealEvent/PageRevealEvent
This pull request has merge conflicts that must be resolved before it can be merged. |
This pull request has merge conflicts that must be resolved before it can be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see the constructor in https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/view_transition/page_reveal_event.idl so this seems to be correct.
This is a supporting feature for authors to work with cross-document view transitions. It is expected that, today, usage is low. I'm currently OOO but maybe @noamr can chime in to why the constructor doesn't show up in the IDL? |
It's an oversight, filed https://issues.chromium.org/issues/354588516 |
This PR removes the
PageRevealEvent
member of thePageRevealEvent
API from BCD. Per the data guidelines, this feature can be considered irrelevant and may be removed from BCD accordingly. Even if the current data suggests that the feature is supported, lack of support has been confirmed by the mdn-bcd-collector project (v10.11.0).Tests Used: https://mdn-bcd-collector.gooborg.com/tests/api/PageRevealEvent/PageRevealEvent