Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ff125 shadowroot serializable #23088

Merged
merged 4 commits into from
May 28, 2024
Merged

Conversation

hamishwillee
Copy link
Collaborator

Chrome 125 adds support for serialiable shadow roots in https://chromestatus.com/feature/5102952270528512 - most of this has been caught before, but we were missing some init values and values for setting this in declaratively created shadow roots.

This is part of mdn/content#32731

@github-actions github-actions bot added data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API data:html 📄 Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML labels May 14, 2024
@@ -2627,9 +2627,10 @@
"deprecated": false
}
},
"init_clonable_parameter": {
"options_clonable_parameter": {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note, changed these to options, because that is what the MDN docs use. I'd be OK with since these are "initialize the shadow root" but options is more common.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah options is more common. I suspect this comes from the IDL which uses init rather than options. 🤷

@@ -2700,6 +2702,41 @@
"deprecated": false
}
}
},
"options_serializable_parameter": {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is new one added in Chrome 125

Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hamishwillee

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API data:html 📄 Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants