Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark Worker name option as available under android_webview #22846

Merged
merged 1 commit into from
May 7, 2024

Conversation

sbc100
Copy link
Contributor

@sbc100 sbc100 commented Apr 16, 2024

This was originally added as unavailable back in 2018 (#3049). However, testing using the android webview shell shows that it is working fine.

Test results and supporting details

The test I used was:

new Worker(URL.createObjectURL(new Blob(["console.log('my name is ' + self.name)"], {type: 'application/javascript'})), {name: "foo"})

I ran this is DevTools and it printed my name is foo.

Related issues

emscripten-core/emscripten#21701 (comment)

This was originally added as unavailable back in 2018 (mdn#3049).  However,
testing using the android webview shell shows that it is working fine.

The test I used was:

```
new Worker(URL.createObjectURL(new Blob(["console.log('my name is ' + self.name)"], {type: 'application/javascript'})), {name: "foo"})
```

I ran this is DevTools and it printed `my name is foo`.
@github-actions github-actions bot added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Apr 16, 2024
@sbc100
Copy link
Contributor Author

sbc100 commented Apr 16, 2024

I assume "mirror" here means "mirror the desktop chrome compat info"?

@skyclouds2001
Copy link
Contributor

Almost the same meaning.

Copy link
Collaborator

@queengooborg queengooborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there, thank you for your PR and welcome to BCD! This seems good to me, and it's safe to say that it was supported since Chrome Android supported it!

(Also, yes, mirroring means "copy from the upstream browser" -- in this case, it's Chrome Android!)

@queengooborg queengooborg merged commit 065f19e into mdn:main May 7, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants