-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the item* microdata attributes (not supported by browsers) #21978
Conversation
The API reflecting these attributes was removed already: mdn#16226 The attributes have never had any effect beyond the API for accessing them, so it's fair to say these attributes are not supported. A search for "itemscope" in the source of Chromium, Gecko and WebKit finds only old tests and similar, no code handling the attribute.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we remove these completely then? Seems like they meet the criteria: https://github.com/mdn/browser-compat-data/blob/main/docs/data-guidelines/index.md#removal-of-irrelevant-features
@Elchi3 they are documented on MDN and I think that makes sense since they're used by https://schema.org/docs/gs.html and probably other things. Should content be updated to just not have a BCD key then? |
hm, I guess I would remove the compat tables on MDN and leave a note there saying that browsers do not necessarily need to support this. I mean so that absent a compat table readers are not wondering about the compat story. |
I mean an all-false table also leaves the wrong impression that this is unusable, right? |
Just removing the compat tables sounds good to me. Do you want me to do that before we move forward with this PR then? |
That would be great, yes! Thank you! |
I've sent mdn/content#32926 to drop the compat tables. Should I just remove these entries from BCD then? |
Yes, please remove them in this PR. And as Will says in mdn/content#32926 (review) use mdn/content's front-matter yaml to provide the spec url for these features in content directly then. |
* Remove browser compat tables for microdata Goes with mdn/browser-compat-data#21978. * Add spec-urls
mdn/content#32926 is merged now, so this should be good to go too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! 👍
The API reflecting these attributes was removed already:
#16226
The attributes have never had any effect beyond the API for accessing
them, so it's fair to say these attributes are not supported.
A search for "itemscope" in the source of Chromium, Gecko and WebKit
finds only old tests and similar, no code handling the attribute.
MDN content update: mdn/content#32926