Use yargs to parse the arguments passed to the linter #2155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elchi3
added
the
linter 🏡
ExE-Boss
force-pushed
the
linter/yargs
branch
2 times, most recently
from
968f561
to
7f8e998
Compare
This makes it possible to manually lint multiple files at once without needing to run the linter multiple times. Also probably fixes the issue where an error in a single file would cause all subsequent files to be printed at the end¹. # References: ¹ https://travis-ci.org/mdn/browser-compat-data/builds/383532922#L7191
Elchi3
requested changes
Oct 5, 2018
| @@ -26,7 +26,8 @@ | |||
| "homepage": "https://github.com/mdn/browser-compat-data#readme", | |||
| "devDependencies": { | |||
| "ajv": "^5.0.1", | |||
| "mdn-confluence": "0.0.7" | |||
| "mdn-confluence": "0.0.7", | |||
| "yargs": "^11.1.0" | |||
There was a problem hiding this comment.
Sorry for not having a look at this earlier, but meanwhile yargs comes with version 12.
There was a problem hiding this comment.
Well, yargs was at version 11 when I made this, and it’s version 11.1 that’s in the node_modules tree:
browser-compat-data/package-lock.json
Lines 2103 to 2104 in f4f8ce8
There was a problem hiding this comment.
Alright, let go with this version for now then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it possible to manually lint multiple files at once without needing to run the linter multiple times.
Also probably fixes the odd issue where an error in a single file would cause all subsequent files to be printed at the end, which is also present in the build for #2156.
Depends on #2288
P.S.:
yargs@^11.1.0is already present in the tree because ofmdn‑confluence.